Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Strings methods other than MediaType #9126

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Aug 4, 2023

This refactors all of the remaining utility methods (except those that convert MediaType and XContentBuilder to String) from the :server to :libs:opensearch-core library. This commit is to keep the Strings refactor surface area lean in preparation for cloud native and serverless refactoring.

relates #5910
relates #8110

This refactors all of the remaining utility methods (except those
that convert MediaType and XContentBuilder to String) from the
:server to :libs:opensearch-core library. This commit is to keep the
Strings refactor surface area lean in preparation for cloud native and
serverless refactoring.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #9126 (b40332f) into main (5bb7fa3) will decrease coverage by 0.01%.
The diff coverage is 67.60%.

❗ Current head b40332f differs from pull request most recent head dc4f3db. Consider uploading reports for the commit dc4f3db to get more accurate results

@@             Coverage Diff              @@
##               main    #9126      +/-   ##
============================================
- Coverage     71.02%   71.01%   -0.01%     
+ Complexity    57286    57263      -23     
============================================
  Files          4765     4765              
  Lines        270398   270397       -1     
  Branches      39546    39546              
============================================
- Hits         192045   192035      -10     
- Misses        62191    62218      +27     
+ Partials      16162    16144      -18     
Files Changed Coverage Δ
...luster/snapshots/create/CreateSnapshotRequest.java 69.93% <ø> (-1.23%) ⬇️
...cluster/metadata/MetadataIndexTemplateService.java 81.80% <0.00%> (ø)
...r/src/main/java/org/opensearch/common/Strings.java 66.66% <ø> (-4.77%) ⬇️
...pensearch/common/settings/PropertyPlaceholder.java 92.45% <ø> (ø)
...apshots/blobstore/BlobStoreIndexShardSnapshot.java 73.05% <ø> (-0.52%) ⬇️
...ch/repositories/blobstore/BlobStoreRepository.java 61.58% <ø> (+0.21%) ⬆️
...ava/org/opensearch/snapshots/SnapshotsService.java 47.55% <33.33%> (-2.29%) ⬇️
.../main/java/org/opensearch/core/common/Strings.java 66.32% <68.75%> (+1.75%) ⬆️
...h/cluster/metadata/MetadataCreateIndexService.java 79.01% <100.00%> (-0.37%) ⬇️
...g/opensearch/repositories/RepositoriesService.java 72.24% <100.00%> (ø)

... and 460 files with indirect coverage changes

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git]
Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 37m 55s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Aug 5, 2023

Another unrelated fail:

./gradlew ':server:internalClusterTest' --tests "org.opensearch.remotestore.ReplicaToPrimaryPromotionIT.testFailoverWhileIndexing" -Dtests.seed=F2F6C4BC55C5DA92 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ru-RU -Dtests.timezone=Europe/Podgorica -Druntime.java=20

Merging.

@nknize nknize merged commit 1d28fac into opensearch-project:main Aug 5, 2023
6 of 8 checks passed
@nknize nknize added the backport 2.x Backport to 2.x branch label Aug 5, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 5, 2023
This refactors all of the remaining utility methods (except those
that convert MediaType and XContentBuilder to String) from the
:server to :libs:opensearch-core library. This commit is to keep the
Strings refactor surface area lean in preparation for cloud native and
serverless refactoring.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 1d28fac)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nknize pushed a commit that referenced this pull request Aug 5, 2023
This refactors all of the remaining utility methods (except those
that convert MediaType and XContentBuilder to String) from the
:server to :libs:opensearch-core library. This commit is to keep the
Strings refactor surface area lean in preparation for cloud native and
serverless refactoring.


(cherry picked from commit 1d28fac)

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
)

This refactors all of the remaining utility methods (except those
that convert MediaType and XContentBuilder to String) from the
:server to :libs:opensearch-core library. This commit is to keep the
Strings refactor surface area lean in preparation for cloud native and
serverless refactoring.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
)

This refactors all of the remaining utility methods (except those
that convert MediaType and XContentBuilder to String) from the
:server to :libs:opensearch-core library. This commit is to keep the
Strings refactor surface area lean in preparation for cloud native and
serverless refactoring.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
)

This refactors all of the remaining utility methods (except those
that convert MediaType and XContentBuilder to String) from the
:server to :libs:opensearch-core library. This commit is to keep the
Strings refactor surface area lean in preparation for cloud native and
serverless refactoring.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants