Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Refactor] Strings methods other than MediaType #9128

Merged
merged 1 commit into from
Aug 5, 2023
Merged

[Backport 2.x] [Refactor] Strings methods other than MediaType #9128

merged 1 commit into from
Aug 5, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1d28fac from #9126.

@github-actions
[Refactor] Strings methods other than MediaType (#9126)
9856e55 
This refactors all of the remaining utility methods (except those
that convert MediaType and XContentBuilder to String) from the
:server to :libs:opensearch-core library. This commit is to keep the
Strings refactor surface area lean in preparation for cloud native and
serverless refactoring.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 1d28fac)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor Author

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 25m 4s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #9128 (9856e55) into 2.x (e59b21a) will decrease coverage by 0.09%.
The diff coverage is 67.60%.

@@             Coverage Diff              @@
##                2.x    #9128      +/-   ##
============================================
- Coverage     70.81%   70.73%   -0.09%     
+ Complexity    57425    57420       -5     
============================================
  Files          4754     4754              
  Lines        271688   271687       -1     
  Branches      40070    40070              
============================================
- Hits         192408   192184     -224     
- Misses        62717    63047     +330     
+ Partials      16563    16456     -107
Files Changed Coverage Δ
...luster/snapshots/create/CreateSnapshotRequest.java 71.51% <ø> (+1.21%) ⬆️
...cluster/metadata/MetadataIndexTemplateService.java 81.80% <0.00%> (-1.13%) ⬇️
...r/src/main/java/org/opensearch/common/Strings.java 66.66% <ø> (-4.77%) ⬇️
...pensearch/common/settings/PropertyPlaceholder.java 92.45% <ø> (ø)
...apshots/blobstore/BlobStoreIndexShardSnapshot.java 73.57% <ø> (+1.03%) ⬆️
...ch/repositories/blobstore/BlobStoreRepository.java 59.65% <ø> (+0.06%) ⬆️
...ava/org/opensearch/snapshots/SnapshotsService.java 40.15% <33.33%> (+0.22%) ⬆️
.../main/java/org/opensearch/core/common/Strings.java 66.32% <68.75%> (+1.75%) ⬆️
...h/cluster/metadata/MetadataCreateIndexService.java 78.57% <100.00%> (-0.18%) ⬇️
...g/opensearch/repositories/RepositoriesService.java 72.57% <100.00%> (+0.33%) ⬆️

... and 468 files with indirect coverage changes

@nknize nknize merged commit 58ca736 into 2.x Aug 5, 2023
7 of 32 checks passed
@github-actions github-actions bot deleted the backport/backport-9126-to-2.x branch August 5, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nknize