Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Normalizers #8192

Merged

Conversation

leanneeliatra
Copy link
Contributor

Description

Addition of some information on normalisers onto the index page for Text analysis

Issues Resolved

Addresses part of #1483

Version

all

Frontend features

n/a

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Sep 6, 2024

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws
Copy link
Collaborator

@leanneeliatra Please fix DCO when you have time. Thanks!

@vagimeli vagimeli added 3 - Tech review PR: Tech review in progress Content gap labels Sep 6, 2024
@vagimeli
Copy link
Collaborator

vagimeli commented Sep 6, 2024

@udabhas Please review and approve for technical accuracy. Thank you.

Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
_analyzers/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc review complete. I'll move this forward to editorial.

@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress labels Sep 13, 2024
Copy link

@udabhas udabhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leanneeliatra @vagimeli Just a few changes. Thanks!

_analyzers/index.md Outdated Show resolved Hide resolved
_analyzers/index.md Outdated Show resolved Hide resolved
_analyzers/index.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com>
@leanneeliatra
Copy link
Contributor Author

@leanneeliatra @vagimeli Just a few changes. Thanks!

Thanks Nate they have been addressed & merged

@leanneeliatra
Copy link
Contributor Author

@vagimeli I accidentally closed this PR. Reopening.
The comments from the editorial review have been addressed and merged and the PR has been reviewed.
This PR is now ready for the next step/closing as per @vagimeli instructions.

@leanneeliatra leanneeliatra reopened this Sep 17, 2024
@natebower natebower added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 5 - Editorial review PR: Editorial review in progress labels Sep 18, 2024
@leanneeliatra leanneeliatra changed the title Updating introduction page with normalisation information Normalizers - added to the docs Sep 23, 2024
@leanneeliatra leanneeliatra changed the title Normalizers - added to the docs Normalizers - addition Sep 23, 2024
@leanneeliatra leanneeliatra changed the title Normalizers - addition Normalizers - addition to docs Sep 23, 2024
@leanneeliatra leanneeliatra changed the title Normalizers - addition to docs [DOC] Normalizers Sep 23, 2024
@vagimeli vagimeli added backport 2.17 Backport for version 2.17 and removed 6 - Done but waiting to merge PR: The work is done and ready to merge labels Sep 24, 2024
@vagimeli vagimeli merged commit 53b650f into opensearch-project:main Sep 24, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 24, 2024
* updating index page with normalisation

Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>

* Update _analyzers/index.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _analyzers/index.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com>

---------

Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com>
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
(cherry picked from commit 53b650f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.17 Backport for version 2.17 Content gap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants