Build test Darwin version of min OpenSearch distribution to support plugin testing on MacOS. #2216

prudhvigodithi · 2022-06-20T20:01:57Z

Is your feature request related to a problem? Please describe

For k-NN, to run integ tests on Mac is not compatible.
KNN uses lang painless to inject scripts. To test on MacOS right now the options are INTEG_TEST, which will bring up a cluster with plain and no modules (mainly lang painless) except transportModulesFiles
Second option is to use ARCHIVE which will allow direct download of zip and test bringing up the cluster, which looks for darwin zip, which is not available for testing.

opensearch-project/OpenSearch#1676

Describe the solution you'd like

Test the existing build_workflow to run the OpenSearch build with platform as darwin.
Test the existing build_workflow to run the OpenSearch build with platform as darwin. #2350
Run the existing distribution build job on MacOS ec2 agent which outputs the min distribution of OpenSearch of type Darwin.
Add a new darwin build stage to OpenSearch distribution pipeline #2361
Build a Mac ec2 AMI able to execute build_workflow and assemble_workflow that can generate OpenSrearch min distribution.
Formalize the MacOS agent's AMI creation using packer. opensearch-ci#163
Automate the Mac jenkins agents creation and add to Public Jenkins.
Add agent configuration support Mac jenkins agents opensearch-ci#157
Add required missing packages to MacOS agents, that support signing workflow, to sign and upload darwin artifacts
[Bug]: Missing required packages on macOS agents. #2375
MacOS agents support default /bin/bash, remove nodeProperties in CDK code and allow jenkins to use default PATH part of AMI.
MacOS agents support default /bin/bash and remove nodeProperties in CDK code. opensearch-ci#174
Validate the darwin artifacts built using the distribution-build job.
Jenkins build Mac 2.2.0-SNAPSHOT

Describe alternatives you've considered

Other alternatives is to test on Linux, Docker but this requires developers with MacOs to setup alternative virtual machines to test the plugins.

Additional context

#38 (comment)

Acceptance Criteria

Test using the existing assemble task from OpenSearch distribution:archives:darwin-arm64-tar:assemble to build the darwin min distribution, integrate with build workflow to automate the min distribution creation.
Test with cross compile framework to build darwin min distribution with existing build workflow.
Approach to be considered: directly run the build workflow on mac ec2 instance that has supported architecture MACHTYPE=x86_64

The text was updated successfully, but these errors were encountered:

jmazanec15 · 2022-07-06T15:59:02Z

Hi @prudhvigodithi and @bbarani, how much effort will this take to do/what release will this be targeted for? Do we already have support for MacOS ec2 agent's? Are there any tasks on this I could pick up?

prudhvigodithi · 2022-07-26T20:42:27Z

Hey we have development version of Darwin min artifact out for testing. This is not a production ready distribution but can be used for development. You can use the below URL (as a reference) to download the Darwin min artifact corresponding to specific OpenSearch version ( >2.1 version )

2.1.1 Mac -min artifact can be downloaded from
https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.1.1/latest/darwin/x64/tar/builds/opensearch/dist/opensearch-min-2.1.1-darwin-x64.tar.gz
2.2.0 Mac -min artifact can be downloaded from

https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.2.0/latest/darwin/x64/tar/builds/opensearch/dist/opensearch-min-2.2.0-darwin-x64.tar.gz

Please test and provide your feedback. Thanks!
Thank you
@bbarani @jmazanec15

jmazanec15 · 2022-07-26T21:18:42Z

Thanks @prudhvigodithi!

When running:

./gradlew build 
...
> Task :integTest FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':integTest'.
> Could not resolve all files for configuration ':opensearch_distro_extracted_testclusters--integTest-0-2.1.1-SNAPSHOT-'.
   > Could not resolve opensearch-distribution-snapshot:opensearch:2.1.1-SNAPSHOT.
     Required by:
         project :
      > Could not resolve opensearch-distribution-snapshot:opensearch:2.1.1-SNAPSHOT.
         > Could not get resource 'https://artifacts.opensearch.org/snapshots/core/opensearch/2.1.1-SNAPSHOT/opensearch-min-2.1.1-SNAPSHOT-darwin-x64-latest.tar.gz'.
            > Could not HEAD 'https://artifacts.opensearch.org/snapshots/core/opensearch/2.1.1-SNAPSHOT/opensearch-min-2.1.1-SNAPSHOT-darwin-x64-latest.tar.gz'. Received status code 403 from server: Forbidden

However, when downloading custom url and using it, it appears to work (will confirm in about 20 min - accidentally posted comment too soon):

./gradlew build -PcustomDistributionUrl=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.1.1/latest/darwin/x64/tar/builds/opensearch/dist/opensearch-min-2.1.1-darwin-x64.tar.gz
...

jmazanec15 · 2022-07-26T22:04:25Z

However, when downloading custom url and using it, it appears to work (will confirm in about 20 min - accidentally posted comment too soon):
./gradlew build -PcustomDistributionUrl=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.1.1/latest/darwin/x64/tar/builds/opensearch/dist/opensearch-min-2.1.1-darwin-x64.tar.gz
...

Confirmed build was successful!

Is it possible to publish artifact to "https://artifacts.opensearch.org" instead of "https://ci.opensearch.org" so that we dont have to pass -PcustomDistributionUrl flag for building? For opensearchplugin, ARCHIVE defaults to "https://artifacts.opensearch.org"

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

prudhvigodithi · 2022-07-28T22:01:46Z

Is it possible to publish artifact to "https://artifacts.opensearch.org" instead of "https://ci.opensearch.org" so that we dont have to pass -PcustomDistributionUrl flag for building? For opensearchplugin, ARCHIVE defaults to "https://artifacts.opensearch.org"

Hey We now have the darwin min snapshot artifacts accessible via https://artifacts.opensearch.org/, the default URL used in OpenSearch.

Jenkins build Mac 2.2.0-SNAPSHOT https://artifacts.opensearch.org/snapshots/core/opensearch/2.2.0-SNAPSHOT/opensearch-min-2.2.0-SNAPSHOT-darwin-x64-latest.tar.gz

Jenkins build Mac 2.1.1-SNAPSHOT https://artifacts.opensearch.org/snapshots/core/opensearch/2.1.1-SNAPSHOT/opensearch-min-2.1.1-SNAPSHOT-darwin-x64-latest.tar.gz

@jmazanec15 when you get a chance can you please test and update?
Thank you
@bbarani

saratvemulapalli · 2022-07-28T23:25:38Z

Thanks @prudhvigodithi, this is amazing . I happen to work with AD plugin and it works!!

./gradlew build                                                                                                                                                                                 
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Mac OS X 10.16 (x86_64)
  JDK Version           : 14 (Oracle JDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-14.0.2.jdk/Contents/Home
  Random Testing Seed   : 3D7474600A5D2F17
  In FIPS 140 mode      : false
=======================================

> Task :compileJava
Note: /Users/vemsarat/Desktop/workspace/Code/anomaly-detection/src/main/java/org/opensearch/ad/ml/EntityColdStarter.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/vemsarat/Desktop/workspace/Code/anomaly-detection/src/main/java/org/opensearch/ad/task/ADBatchTaskRunner.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
<==========---> 79% EXECUTING [30s]
> :integTest > Resolve files of :opensearch_distro_extracted_testclusters--integTest-0-2.1.1-SNAPSHOT- > opensearch-min-2.1.1-SNAPSHOT-darwin-x64-latest.tar.gz > 141.9 MiB/209.5 MiB downloaded

prudhvigodithi · 2022-07-29T00:27:36Z

Thanks @prudhvigodithi, this is amazing . I happen to work with AD plugin and it works!!

Thanks for testing @saratvemulapalli ;)

prudhvigodithi · 2022-08-01T14:12:17Z

Closing this issue as the tasks part of this META issue are marked complete, please feel free to re-open if required.
Thank you

Arpit-Bandejiya · 2023-03-08T08:51:06Z

Hi @prudhvigodithi while trying to build async-search for 3.0.0 in mac I'm facing the below error:

abandeji@bcd074462b7f asynchronous-search % ./gradlew build -PcustomDistributionUrl=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/3.0.0/latest/darwin/x64/tar/builds/opensearch/dist/opensearch-min-3.0.0-darwin-x64.tar.gz
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Mac OS X 13.2.1 (aarch64)
  JDK Version           : 17 (Amazon Corretto JDK)
  JAVA_HOME             : /Users/abandeji/.sdkman/candidates/java/17.0.6-amzn
  Random Testing Seed   : 9DCE0F0910A72E66
  In FIPS 140 mode      : false
=======================================
> Task :integTest FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':integTest'.
> Could not resolve all files for configuration ':opensearch_distro_extracted_testclusters--integTest-0-3.0.0-SNAPSHOT-'.
   > Could not resolve opensearch-distribution-snapshot:opensearch:3.0.0-SNAPSHOT.
     Required by:
         project :
      > Could not resolve opensearch-distribution-snapshot:opensearch:3.0.0-SNAPSHOT.
         > Could not get resource 'https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/3.0.0/latest/darwin/x64/tar/builds/opensearch/dist/opensearch-min-3.0.0-darwin-x64.tar.gz'.
            > Could not HEAD 'https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/3.0.0/7106/darwin/x64/tar/builds/opensearch/dist/opensearch-min-3.0.0-darwin-x64.tar.gz'. Received status code 403 from server: Forbidden

Is there a way to check the url is correct or not? I'm not able to visit the base ci.opensearch.org as well since it says forbidden on browser.

prudhvigodithi · 2023-03-08T16:39:41Z

Hey @Arpit-Bandejiya the URL is as follows
https://artifacts.opensearch.org/snapshots/core/opensearch/3.0.0-SNAPSHOT/opensearch-min-3.0.0-SNAPSHOT-darwin-x64-latest.tar.gz
Also if you are by default using a mac workspace the default pulled should be a darwin min. All the snapshots are stored in artifacts.opensearch.org, so if you still want to use -PcustomDistributionUrl then the command is as follows

./gradlew build -PcustomDistributionUrl=https://artifacts.opensearch.org/snapshots/core/opensearch/3.0.0-SNAPSHOT/opensearch-min-3.0.0-SNAPSHOT-darwin-x64-latest.tar.gz

Please try with this and let me know.
Thank you

Arpit-Bandejiya · 2023-03-09T04:25:19Z

This works @prudhvigodithi thanks!

Arpit-Bandejiya · 2023-03-10T11:42:55Z

@prudhvigodithi I have one question though when I build it without passing this flag, I get this error:

* What went wrong:
Execution failed for task ':integTest'.
> Could not resolve all files for configuration ':opensearch_distro_extracted_testclusters--integTest-0-3.0.0-SNAPSHOT-'.
   > Could not resolve opensearch-distribution-snapshot:opensearch:3.0.0-SNAPSHOT.
     Required by:
         project :
      > Could not resolve opensearch-distribution-snapshot:opensearch:3.0.0-SNAPSHOT.
         > Could not get resource 'https://artifacts.opensearch.org/snapshots/core/opensearch/3.0.0-SNAPSHOT/opensearch-min-3.0.0-SNAPSHOT-darwin-arm64-latest.tar.gz'.
            > Could not HEAD 'https://artifacts.opensearch.org/snapshots/core/opensearch/3.0.0-SNAPSHOT/opensearch-min-3.0.0-SNAPSHOT-darwin-arm64-latest.tar.gz'. Received status code 403 from server: Forbidden

As can be seen the url is same as one we passed in command line. Any possible reason of this failing?

prudhvigodithi · 2023-03-10T16:18:28Z

Hey @Arpit-Bandejiya We are publishing darwin x64, the URL is not same if you notice it is going to arm64 (from your screenshot opensearch-min-3.0.0-SNAPSHOT-darwin-arm64-latest.tar.gz)

Sample Download URL:
https://artifacts.opensearch.org/snapshots/core/opensearch/3.0.0-SNAPSHOT/opensearch-min-3.0.0-SNAPSHOT-darwin-x64-latest.tar.gz

Mac os support x86_64 and arm64 as well, mac m1 works for both x86_64 and arm64 with help of Rosetta 2
arm64 is the architecture used by newer Macs built on Apple Silicon, shipped in late 2020 and beyond, but x64 should work as well, pgrep oahd should output the Rosetta process

Useful blog's:
https://eclecticlight.co/2021/01/22/running-intel-code-on-your-m1-mac-rosetta-2-and-oah/
https://docs.elementscompiler.com/Platforms/Cocoa/CpuArchitectures/#:~:text=On%20macOS%2C%20two%20architecture%20are,in%20late%202020%20and%20beyond.

So in your case please use -PcustomDistributionUrl.

prudhvigodithi added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Jun 20, 2022

prudhvigodithi changed the title ~~Build test Darwin min OpenSearch distribution to support plugin testing on MacOS.~~ Build test Darwin version of min OpenSearch distribution to support plugin testing on MacOS. Jun 20, 2022

bbarani removed the untriaged Issues that have not yet been triaged label Jun 22, 2022

bbarani assigned prudhvigodithi Jun 22, 2022

navneet1v mentioned this issue Jul 22, 2022

[BUG] ./gradlew bwcTest is broken opensearch-project/OpenSearch#1855

Closed

prudhvigodithi added the Meta label Jul 22, 2022

This was referenced Jul 22, 2022

Add a new darwin build stage to OpenSearch distribution pipeline #2361

Closed

Add a new darwin build stage to OpenSearch distribution pipeline #2362

Merged

prudhvigodithi mentioned this issue Jul 27, 2022

Darwin add min snapshot stage. #2374

Merged

bbarani mentioned this issue Jul 27, 2022

[Bug]: Checksum check failing for OpenSearch #2114

Closed

prudhvigodithi mentioned this issue Jul 28, 2022

MacOS agents support default /bin/bash and remove nodeProperties in CDK code. opensearch-project/opensearch-ci#175

Merged

prudhvigodithi added a commit to prudhvigodithi/opensearch-build that referenced this issue Jul 28, 2022

Fix ci issue opensearch-project#2216

eae5730

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

This was referenced Jul 28, 2022

MacOS agents support default /bin/bash and remove nodeProperties in CDK code. opensearch-project/opensearch-ci#174

Closed

[Bug]: Missing required packages on macOS agents. #2375

Closed

This was referenced Jul 29, 2022

Remove build-macos-x64-tar stage. #2384

Closed

Remove build-macos-x64-tar stage #2388

Merged

prudhvigodithi closed this as completed Aug 1, 2022

prudhvigodithi mentioned this issue Nov 15, 2023

Publish OpenSearch min snapshots for Mac M1 machines #4131

Closed

peterzhuamazon mentioned this issue May 2, 2024

Support aarch64 OpenSearch distribution for MacOS architecture #4670

Closed

prudhvigodithi mentioned this issue May 29, 2024

Remove macos platform for OSD builds #4729

Merged

peterzhuamazon mentioned this issue Aug 29, 2024

Build a Opensearch Dashboard min distribution for Mac #4970

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build test Darwin version of min OpenSearch distribution to support plugin testing on MacOS. #2216

Build test Darwin version of min OpenSearch distribution to support plugin testing on MacOS. #2216

prudhvigodithi commented Jun 20, 2022 •

edited

Loading

jmazanec15 commented Jul 6, 2022

prudhvigodithi commented Jul 26, 2022 •

edited

Loading

jmazanec15 commented Jul 26, 2022 •

edited

Loading

jmazanec15 commented Jul 26, 2022

prudhvigodithi commented Jul 28, 2022 •

edited

Loading

saratvemulapalli commented Jul 28, 2022 •

edited

Loading

prudhvigodithi commented Jul 29, 2022

prudhvigodithi commented Aug 1, 2022

Arpit-Bandejiya commented Mar 8, 2023

prudhvigodithi commented Mar 8, 2023

Arpit-Bandejiya commented Mar 9, 2023

Arpit-Bandejiya commented Mar 10, 2023

prudhvigodithi commented Mar 10, 2023

Build test Darwin version of min OpenSearch distribution to support plugin testing on MacOS. #2216

Build test Darwin version of min OpenSearch distribution to support plugin testing on MacOS. #2216

Comments

prudhvigodithi commented Jun 20, 2022 • edited Loading

Is your feature request related to a problem? Please describe

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Acceptance Criteria

jmazanec15 commented Jul 6, 2022

prudhvigodithi commented Jul 26, 2022 • edited Loading

jmazanec15 commented Jul 26, 2022 • edited Loading

jmazanec15 commented Jul 26, 2022

prudhvigodithi commented Jul 28, 2022 • edited Loading

saratvemulapalli commented Jul 28, 2022 • edited Loading

prudhvigodithi commented Jul 29, 2022

prudhvigodithi commented Aug 1, 2022

Arpit-Bandejiya commented Mar 8, 2023

prudhvigodithi commented Mar 8, 2023

Arpit-Bandejiya commented Mar 9, 2023

Arpit-Bandejiya commented Mar 10, 2023

prudhvigodithi commented Mar 10, 2023

prudhvigodithi commented Jun 20, 2022 •

edited

Loading

prudhvigodithi commented Jul 26, 2022 •

edited

Loading

jmazanec15 commented Jul 26, 2022 •

edited

Loading

prudhvigodithi commented Jul 28, 2022 •

edited

Loading

saratvemulapalli commented Jul 28, 2022 •

edited

Loading