-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/backport 211 to 1.x #239
Merged
dhrubo-os
merged 7 commits into
opensearch-project:1.x
from
thanawan-atc:backport/backport-211-to-1.x
Aug 22, 2023
Merged
Backport/backport 211 to 1.x #239
dhrubo-os
merged 7 commits into
opensearch-project:1.x
from
thanawan-atc:backport/backport-211-to-1.x
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updating notebook + bumping version Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit 1237aa6)
* Add description field Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Restore notebook Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug test Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Resolve linting issues Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug test_sentencetransformermodel_pytest.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve test coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Edit test name Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change CHANGELOG.md & Add comment to sentencetransformermodel.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve add description Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Loosen restriction Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update sentencetransformermodel.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change function name + Add comment + Add default description Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 20435b1)
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.x #239 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 38 38
Lines 4199 4199
=======================================
Hits 3834 3834
Misses 365 365 |
dhrubo-os
approved these changes
Aug 22, 2023
rbhavna
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport PR #211
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.