Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/backport 211 to 1.x #239

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Backport/backport 211 to 1.x #239

merged 7 commits into from
Aug 22, 2023

Commits on Aug 10, 2023

  1. updating notebook + bumping version (#199) 

    * updating notebook + bumping version

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* addressing comments

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
(cherry picked from commit 1237aa6)
    @dhrubo-os @thanawan-atc
    dhrubo-os authored and thanawan-atc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    16184b8 View commit details
    Browse the repository at this point in the history

  2. Add description field with make_model_config_json function (#203) 

    * Add description field

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Restore notebook

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Debug test

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Resolve linting issues

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Update CHANGELOG.md

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Debug test_sentencetransformermodel_pytest.py

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Improve test coverage

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Edit test name

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Change CHANGELOG.md & Add comment to sentencetransformermodel.py

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Correct linting

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Improve add description

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Correct linting

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Loosen restriction

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Update sentencetransformermodel.py

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Change function name + Add comment + Add default description

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

* Debug

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>

---------

Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
(cherry picked from commit 20435b1)
    @thanawan-atc
    thanawan-atc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    eac5f7b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'thanawan-atc-backport/backport-203-to-1.x' into 1.x

    @thanawan-atc
    thanawan-atc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    a0e4a5a View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Backport 

    Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
    @thanawan-atc
    thanawan-atc committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8557d02 View commit details
    Browse the repository at this point in the history

  2. Merge branch '1.x' into backport/backport-211-to-1.x 

    Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
    @thanawan-atc
    thanawan-atc committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0dd8921 View commit details
    Browse the repository at this point in the history

  3. Fix linting 

    Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
    @thanawan-atc
    thanawan-atc committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    dd54c21 View commit details
    Browse the repository at this point in the history

  4. Update test_sentencetransformermodel_pytest.py 

    Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
    @thanawan-atc
    thanawan-atc committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2074326 View commit details
    Browse the repository at this point in the history