-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index State Management support #398
Index State Management support #398
Conversation
ec7e13b
to
98fe5d0
Compare
c7b3e74
to
aba6342
Compare
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 70.88% 70.87% -0.01%
==========================================
Files 79 81 +2
Lines 7576 7664 +88
==========================================
+ Hits 5370 5432 +62
- Misses 2206 2232 +26
|
Hello @florianvazelle, I notice some of Integration Tests and Lint tests are failing. Please try to fix them. Thank you. |
Hi @saimedhi, some tests seems to start opensearch without ISM plugin. Is this normal ? https://github.com/opensearch-project/opensearch-py/actions/runs/5333494406/jobs/9664033038 |
Hi @florianvazelle, I am not completely sure but I suggest to take a look at other existing plugin tests. I have gone through Alerting plugin tests. They are passing for "integration" tests and skipped for "Integration with Unreleased Opensearch" tests. So, please take a look at those tests once. Thanks :) |
5828d9f
to
368a7d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small request to move plugin tests into separate file(s). Please do for existing ones if this isn't the case.
022e8ab
to
ad77659
Compare
Looks good, needs a rebase + user guides. |
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
ad77659
to
75d40ea
Compare
Signed-off-by: florian <florian@harfanglab.fr>
75d40ea
to
6acc012
Compare
@dblock done ! 🙂 |
@@ -21,6 +21,10 @@ | |||
- [**Creating a destination**](#creating-a-destination) | |||
- [**Getting alerts**](#getting-alerts) | |||
- [**Acknowledge alerts**](#acknowledge-alerts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind fixing these **
in another PR? Thanks.
Description
Added support for the ISM API.
Issues Resolved
The issue of managing index states from the python client.
This issue is the subject of a feature request at #284.