-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async tests for plugins #425
Add async tests for plugins #425
Conversation
Codecov Report
@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 71.49% 71.49%
=======================================
Files 81 81
Lines 7668 7668
=======================================
Hits 5482 5482
Misses 2186 2186 |
LGTM, finish it up? |
Hi @dblock, there are two points I'd like to look at:
|
@florianvazelle I wouldn't worry about coverage |
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
da7bc22
to
92fb09e
Compare
@dblock Ok, so It's good to me now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two small changes with the license headers please? Sorry for the hassle.
tl;dr:
- new files only need the SPDX header + first paragraph
- existing files license headers should not be changed
# this file be licensed under the Apache-2.0 license or a | ||
# compatible open source license. | ||
# | ||
# Modifications Copyright OpenSearch Contributors. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the modifications part from new files. That was added during the fork for files that had an ES license before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the utils/license-headers.py
enforce the Modifications Copyright OpenSearch Contributors
part. Should I adapt checks made in the script ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, we can deal with this separately.
# this file be licensed under the Apache-2.0 license or a | ||
# compatible open source license. | ||
# | ||
# Modifications Copyright OpenSearch Contributors. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new file, so I believe everything including and down from Modifications ... should be removed. Just leave the SPDX header and the paragraph that says "The OpenSearch ... open source license.".
Description
Issues Resolved