Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment latency, cpu and memory histograms for query/aggregation/sort query types #30

Merged

Conversation

deshsidd
Copy link
Collaborator

@deshsidd deshsidd commented Jul 17, 2024

Integrate latency and resource usage data to the query categorization data.

Description

Followup for the following, we now increment histograms for latency, cpu and memory for each query type, aggregation type and sort order.

Issues Resolved

resolves opensearch-project/OpenSearch#14588

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…rt types

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Copy link
Collaborator

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, minor comments!

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@deshsidd deshsidd merged commit ed1ccf8 into opensearch-project:main Jul 18, 2024
10 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.16
# Create a new branch
git switch --create backport/backport-30-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed1ccf8884c6bd42e468d697f552e29258318fcf
# Push it to GitHub
git push --set-upstream origin backport/backport-30-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-30-to-2.16.

@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.x
# Create a new branch
git switch --create backport/backport-30-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed1ccf8884c6bd42e468d697f552e29258318fcf
# Push it to GitHub
git push --set-upstream origin backport/backport-30-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-30-to-2.x.

deshsidd added a commit to deshsidd/query-insights that referenced this pull request Jul 22, 2024
…rt query types (opensearch-project#30)

* Increment latency, cpu and memory histograms for query/aggregation/sort types

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
(cherry picked from commit ed1ccf8)
deshsidd added a commit to deshsidd/query-insights that referenced this pull request Jul 22, 2024
…rt query types (opensearch-project#30)

* Increment latency, cpu and memory histograms for query/aggregation/sort types

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
(cherry picked from commit ed1ccf8)
deshsidd added a commit that referenced this pull request Jul 22, 2024
…rt query types (#30) (#38)

* Increment latency, cpu and memory histograms for query/aggregation/sort types

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
(cherry picked from commit ed1ccf8)
deshsidd added a commit that referenced this pull request Jul 22, 2024
…rt query types (#30) (#37)

* Increment latency, cpu and memory histograms for query/aggregation/sort types

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
(cherry picked from commit ed1ccf8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Integrate latency and resource usage data to query categorization metrics
2 participants