Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-17121: Cluster name show validation message when typing characters #2516

Merged
merged 3 commits into from
Mar 13, 2024
Merged

MGMT-17121: Cluster name show validation message when typing characters #2516

merged 3 commits into from
Mar 13, 2024

Conversation

ammont82
Copy link
Contributor

@ammont82 ammont82 commented Mar 6, 2024 •
edited
Loading

Related to https://issues.redhat.com/browse/MGMT-17121 and https://issues.redhat.com/browse/MGMT-17139

We need to change the version of react-core because the Popover focusTrap has an issue: patternfly/patternfly-react#9865 and it was solved in react-core 5.2.version

  1. CLUSTER NAME
    When user type something in cluster name show validation message to see if the cluster name is correct or not:

image

image

  1. MASS HOST RENAME

image

@ammont82 ammont82 added the OCM label Mar 6, 2024
@ammont82 ammont82 added this to the v2.31 milestone Mar 6, 2024
@ammont82 ammont82 requested a review from a team as a code owner March 6, 2024 10:42
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2024 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-17121 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17121

When user type something in cluster name show validation message to see if the cluster name is correct or not:

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2024 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-17121 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17121

When user type something in cluster name show validation message to see if the cluster name is correct or not:

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ammont82 ammont82 force-pushed the MGMT-17121-cluster-name-not-shown-validation-with-illegal-characters branch from fae753d to 4062811 Compare March 7, 2024 10:37
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2024
@ammont82 ammont82 force-pushed the MGMT-17121-cluster-name-not-shown-validation-with-illegal-characters branch from 4062811 to 63f8cc9 Compare March 7, 2024 10:41
@ammont82 ammont82 marked this pull request as draft March 7, 2024 14:25
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2024
@ammont82 ammont82 force-pushed the MGMT-17121-cluster-name-not-shown-validation-with-illegal-characters branch from 63f8cc9 to 5dff9b9 Compare March 8, 2024 10:26
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2024
@ammont82 ammont82 marked this pull request as ready for review March 8, 2024 10:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024
@ammont82 ammont82 force-pushed the MGMT-17121-cluster-name-not-shown-validation-with-illegal-characters branch from 5dff9b9 to 0c0ef14 Compare March 8, 2024 10:28
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 8, 2024 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-17121 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17121 and https://issues.redhat.com/browse/MGMT-17139

  1. CLUSTER NAME
    When user type something in cluster name show validation message to see if the cluster name is correct or not:

image

image

  1. MASS HOST RENAME

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ammont82 ammont82 force-pushed the MGMT-17121-cluster-name-not-shown-validation-with-illegal-characters branch 2 times, most recently from fbfb148 to 148d80a Compare March 8, 2024 11:40
@ammont82 ammont82 force-pushed the MGMT-17121-cluster-name-not-shown-validation-with-illegal-characters branch 2 times, most recently from 6dc1e66 to 8fe122c Compare March 12, 2024 12:10
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2024 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-17121 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17121 and https://issues.redhat.com/browse/MGMT-17139

We need to change the version of react-core because the Popover focusTrap has an issue: patternfly/patternfly-react#9865 and it was solved in react-core 5.2.version

  1. CLUSTER NAME
    When user type something in cluster name show validation message to see if the cluster name is correct or not:

image

image

  1. MASS HOST RENAME

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ammont82 ammont82 force-pushed the MGMT-17121-cluster-name-not-shown-validation-with-illegal-characters branch from 8fe122c to fbeffa1 Compare March 12, 2024 14:07
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
celdrake
celdrake approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@celdrake celdrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the Cluster name input, and works as expected.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 13, 2024

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit bbc690d into openshift-assisted:master Mar 13, 2024
7 checks passed
ammont82 added a commit to ammont82/assisted-installer-ui that referenced this pull request Mar 20, 2024
@ammont82
MGMT-17121: Cluster name show validation message when typing characte…
b740f7d 
…rs (openshift-assisted#2516)

* Cluster name show validation message when typing characters

* Updating react-core version to avoid problems with Popover focus
@ammont82 ammont82 mentioned this pull request Mar 20, 2024
Merged
@ammont82 ammont82 removed this from the v2.31 milestone Mar 20, 2024
ammont82 added a commit that referenced this pull request Mar 20, 2024
@ammont82
MGMT-17121: Cluster name show validation message when typing characte…
408d712 
…rs (#2516) (#2528)

* Cluster name show validation message when typing characters

* Updating react-core version to avoid problems with Popover focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celdrake celdrake celdrake approved these changes

@jgyselov jgyselov jgyselov approved these changes

Assignees

@celdrake celdrake

@jgyselov jgyselov

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OCM size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ammont82 @openshift-ci-robot @celdrake @jgyselov