Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17121: Cluster name show validation message when typing characters - 2.31 #2528

Conversation

ammont82
Copy link
Contributor

backport of #2516

…rs (openshift-assisted#2516)

* Cluster name show validation message when typing characters

* Updating react-core version to avoid problems with Popover focus
@ammont82 ammont82 added this to the v2.31 milestone Mar 20, 2024
@ammont82 ammont82 requested a review from a team as a code owner March 20, 2024 09:46
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024

@ammont82: This pull request references MGMT-17121 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

backport of #2516

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024

@ammont82: This pull request references MGMT-17121 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

backport of #2516

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

libs/locales/package.json Outdated Show resolved Hide resolved
@ammont82 ammont82 changed the base branch from master to releases/v2.31 March 20, 2024 10:37
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024

@ammont82: This pull request references MGMT-17121 which is a valid jira issue.

In response to this:

backport of #2516

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ammont82 ammont82 requested a review from jgyselov March 20, 2024 10:37
jgyselov
jgyselov previously approved these changes Mar 20, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
celdrake
celdrake previously approved these changes Mar 20, 2024
@ammont82 ammont82 dismissed stale reviews from celdrake and jgyselov via 063e115 March 20, 2024 13:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
Copy link

openshift-ci bot commented Mar 20, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit 408d712 into openshift-assisted:releases/v2.31 Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants