[OCMUI-1145] PreviewBadge: allow ReactNode content #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/S
cben
force-pushed
the
PreviewBadge-content
branch
from
8cca18a
to
7d31baf
Compare
|
@ammont82 please review |
ammont82
approved these changes
Apr 24, 2024
jgyselov
approved these changes
Apr 24, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82, cben, jgyselov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation: In OCM we have use case for showing dynamic badge content (https://issues.redhat.com/browse/OCMUI-1145) where we don't get separate "Learn More" URL but might render links in the text itself. The existing `PreviewBadge` component supports this fine at run time, only the `popoverText: string` type was too restrictive at compile time. => Relaxing the type + renames `popoverText` -> `popoverContent`.
cben
force-pushed
the
PreviewBadge-content
branch
from
60b5e5a
to
7447268
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: In OCM we have use case for showing dynamic badge content (https://issues.redhat.com/browse/OCMUI-1145) where we don't get separate "Learn More" URL but might render links in the text itself.
The existing
PreviewBadgecomponent supports this fine at run time, only thepopoverText: stringtype was too restrictive at compile time.popoverText->popoverContentaccordingly. Can drop this part if there is any concern?With the ongoing de-coupling of our codebases, I'm not sure we'll end up using this — but seems harmless enough?
Missing internal module 'internal/deps/./lib/client'...)yarn build:allpassed.