Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCMUI-1145] PreviewBadge: allow ReactNode content #2560

Merged
merged 1 commit into from
Apr 25, 2024

Commits on Apr 25, 2024

  1. PreviewBadge: allow ReactNode content, rename prop to popoverContent

    Motivation: In OCM we have use case for showing dynamic badge content
    (https://issues.redhat.com/browse/OCMUI-1145) where we don't get separate
    "Learn More" URL but might render links in the text itself.
    
    The existing `PreviewBadge` component supports this fine at run time,
    only the `popoverText: string` type was too restrictive at compile time.
    => Relaxing the type + renames `popoverText` -> `popoverContent`.
    cben committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7447268 View commit details
    Browse the repository at this point in the history