Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.12] fix: only add triggerAuth to scaled objects when there is an actual value to reference (#3941) #1118

Open
wants to merge 2 commits into
base: release-v1.12
Choose a base branch
from
Open

[release-v1.12] fix: only add triggerAuth to scaled objects when there is an actual value to reference (#3941) #1118

wants to merge 2 commits into from

Conversation

Cali0707
Copy link
Member

A backport of knative-extensions#3941 to fix errors on KEDA scaled objects when there is no need for an authentication reference

@Cali0707
fix: only add triggerAuth to scaled objects when there is an actual v…
6317e2a 
…alue to reference (knative-extensions#3941)

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Member Author

/hold until I add a regression test

@openshift-ci openshift-ci bot requested review from creydr and lberk June 21, 2024 14:49
@Cali0707
Copy link
Member Author

/cc @pierDipi

@openshift-ci openshift-ci bot requested a review from pierDipi June 21, 2024 14:50
@Cali0707
Copy link
Member Author

/unhold
This should be ready for review now @pierDipi

@matzew
Copy link
Member

matzew commented Jul 5, 2024

/retest

1 similar comment
@matzew
Copy link
Member

matzew commented Jul 8, 2024

/retest

pierDipi
pierDipi approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 31, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

11 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

28 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 044346c and 2 for PR HEAD c19dc53 in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 20, 2024

@Cali0707: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/415-test-reconciler-encryption-auth-aws-415 c19dc53 link true /test 415-test-reconciler-encryption-auth-aws-415
ci/prow/415-test-reconciler-aws-415 c19dc53 link true /test 415-test-reconciler-aws-415
ci/prow/415-test-reconciler-keda-aws-415 c19dc53 link true /test 415-test-reconciler-keda-aws-415

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@creydr creydr Awaiting requested review from creydr

@lberk lberk Awaiting requested review from lberk

Assignees

@pierDipi pierDipi

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cali0707 @matzew @pierDipi @openshift-ci-robot