Fix service deps for ovs-configuration #3361
Conversation
In openshift#3233 we changed the order of dependencies for ovs-configuration and nodeip-configuration. However, because nodeip-configuration doesn't run everywhere, this means ovs-configuration lost its depenedency on NetworkManager-wait-online in some cases. Since the first patch merged, some upgrade jobs have been having issues that seem to be related to that change. It's not entirely clear why, but since this was an unintended change to the dependencies it seems like a strong candidate. To fix the problem, we can just have the NetworkManager-wait-online dep in both services. When nodeip-configuration runs it will be redundant, but at least ovs-configuration will always wait for it.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cybertron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-azure-ovn-upgrade |
|
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
@cybertron: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This is being done in #3362 now. |
In #3233 we changed the order of dependencies for ovs-configuration and nodeip-configuration. However, because nodeip-configuration doesn't run everywhere, this means ovs-configuration lost its depenedency on NetworkManager-wait-online in some cases. Since the first patch merged, some upgrade jobs have been having issues that seem to be related to that change. It's not entirely clear why, but since this was an unintended change to the dependencies it seems like a strong candidate.
To fix the problem, we can just have the NetworkManager-wait-online dep in both services. When nodeip-configuration runs it will be redundant, but at least ovs-configuration will always wait for it.
- What I did
- How to verify it
- Description for the changelog