Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE-2962: configure ovs should use node-ip-hint set by nodeip-configuration #3362

Merged

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Oct 3, 2022

RFE-2962: configure ovs should use node-ip-hint set by nodeip-configuration

@tsorya
Copy link
Contributor Author

tsorya commented Oct 3, 2022

/test e2e-azure-ovn-upgrade

@tsorya
Copy link
Contributor Author

tsorya commented Oct 3, 2022

/test e2e-azure-upgrade

@tsorya
Copy link
Contributor Author

tsorya commented Oct 4, 2022

/retest

@cybertron
Copy link
Member

/retest

It looks like this is now working as intended and one azure-upgrade job passed so I expect the ovn one should too.

@jcaamano
Copy link
Contributor

jcaamano commented Oct 4, 2022

/test e2e-aws-ovn-workers-rhel8
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-ovn-step-registry
/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade

@dgoodwin
Copy link
Contributor

dgoodwin commented Oct 4, 2022

Failures in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/3362/pull-ci-openshift-machine-config-operator-master-e2e-azure-ovn-upgrade/1577237776590442497 do not look related. I think we can see enough in presubmits to say no payload command required.

Thanks!

@jcaamano
Copy link
Contributor

jcaamano commented Oct 5, 2022

Failures seem unrelated. Going for another round just in case.

/retest

@jcaamano
Copy link
Contributor

jcaamano commented Oct 5, 2022

/lgtm

@tsorya
Copy link
Contributor Author

tsorya commented Oct 5, 2022

@cgwalters can we get approve?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022
@cgwalters
Copy link
Member

/approve
(But since you tagged me I'd just reiterate that I think this logic should be in a Real Programming Language and not shell script - actually if we go down the path of #3137 then our openshift-node-base container image could actually have Go (or Rust 😉 ) code injected, and it wouldn't even need to be an RPM...)

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3589316 and 2 for PR HEAD e844da3 in total

@tsorya
Copy link
Contributor Author

tsorya commented Oct 6, 2022

/retest

@tsorya
Copy link
Contributor Author

tsorya commented Oct 6, 2022

Failures seems totally unrelated

@tsorya
Copy link
Contributor Author

tsorya commented Oct 6, 2022

/retest

@flaper87
Copy link
Contributor

flaper87 commented Oct 6, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, flaper87, jcaamano, tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaamano
Copy link
Contributor

jcaamano commented Oct 6, 2022

/retest-required

@tsorya
Copy link
Contributor Author

tsorya commented Oct 6, 2022

/retest

@cybertron
Copy link
Member

/retest-required

@cybertron
Copy link
Member

/test okd-scos-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

@tsorya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-workers-rhel8 e844da3 link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-hypershift e844da3 link false /test e2e-hypershift
ci/prow/e2e-openstack e844da3 link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tsorya
Copy link
Contributor Author

tsorya commented Oct 7, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 2cd6ace into openshift:master Oct 7, 2022
mkowalski added a commit to mkowalski/machine-config-operator that referenced this pull request Mar 23, 2023
When dealing with IPv6 addresses we need to make sure they are bindable
before we report network as ready. The check has been introduced in
openshift#3362 and works
by trying to simply bind to a specified IPv6 address.

The check however doesn't account for the fact that we may have
addresses in the form of IPv4-mapped-on-IPv6. In such a scenario ncat is
returning an "Invalid argument" error because it tries to open a socket
of type `AF_INET6` whereas this type of address requires additional
`IPV6_ADDRFORM` option which ncat is not setting. Another possibility is
to create a socket of type `AF_INET` what could be done by

```
nc -4 -l ::ffff:192.168.0.14 53604
```

In order to workaround this behaviour of netcat, we are ignoring the
bind tests for IPv4-mapped-on-IPv6 address, as due to its nature it will
never be stuck in tentative state even when rest of the infrastrucure is
performing Duplicate Address Detection. As this address belongs to a
special class of addresses, we can afford its special handling.

Closes: OCPBUGS-10695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants