Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended.deploymentconfigs when tagging images [Conformance] should successfully tag the deployed image #10663

Closed
0xmichalis opened this issue Aug 26, 2016 · 17 comments · Fixed by #10664 or #15162
Assignees
Labels
area/tests component/apps kind/test-flake Categorizes issue or PR as related to test flakes. priority/P2
Milestone

Comments

@0xmichalis
Copy link
Contributor

• Failure [28.701 seconds]
deploymentconfigs
/data/src/github.com/openshift/origin/test/extended/deployments/deployments.go:672
  when tagging images
  /data/src/github.com/openshift/origin/test/extended/deployments/deployments.go:270
    should successfully tag the deployed image [Conformance] [It]
    /data/src/github.com/openshift/origin/test/extended/deployments/deployments.go:269

    Expected error:
        <*util.ExitError | 0xc820dbc840>: {
            Cmd: "oc get --namespace=extended-test-cli-deployment-8r7cb-7lf2e --config=/tmp/openshift/extended-test-cli-deployment-8r7cb-7lf2e-user.kubeconfig istag/sample-stream:deployed",
            StdErr: "imagestreamtags \"sample-stream:deployed\" not found",
            ExitError: {
                ProcessState: {
                    pid: 29003,
                    status: 256,
                    rusage: {
                        Utime: {Sec: 0, Usec: 99654},
                        Stime: {Sec: 0, Usec: 19472},
                        Maxrss: 36060,
                        Ixrss: 0,
                        Idrss: 0,
                        Isrss: 0,
                        Minflt: 6600,
                        Majflt: 0,
                        Nswap: 0,
                        Inblock: 0,
                        Oublock: 0,
                        Msgsnd: 0,
                        Msgrcv: 0,
                        Nsignals: 0,
                        Nvcsw: 1821,
                        Nivcsw: 15,
                    },
                },
                Stderr: nil,
            },
        }
        exit status 1
    not to have occurred

    /data/src/github.com/openshift/origin/test/extended/deployments/deployments.go:263
------------------------------

The deployment finished successfully but the image stream wasn't tagged? We should probably poll the image stream for some time.

@soltysh
Copy link
Contributor

soltysh commented Sep 30, 2016

@0xmichalis
Copy link
Contributor Author

The tag hook was successful

Sep 29 09:29:32.578: INFO: At 2016-09-29 09:29:30 -0400 EDT - event for tag-images: {tag-images-1-deploy } Completed: The post-hook for deployment extended-test-cli-deployment-4xulh-f822j/tag-images-1 completed successfully

but the tag is nowhere to be found... Strange.

@0xmichalis
Copy link
Contributor Author

Hm, timeout for the test is 10s.. Will bump and I may want to use tag generation.

@0xmichalis
Copy link
Contributor Author

I cannot use generation because the stream does not exist beforehand. Bumping the timeout in #11204

@soltysh
Copy link
Contributor

soltysh commented Oct 7, 2016

@bparees
Copy link
Contributor

bparees commented Dec 16, 2016

@bparees
Copy link
Contributor

bparees commented Feb 10, 2017

@bparees bparees reopened this Feb 10, 2017
@bparees bparees changed the title should successfully tag the deployed image Extended.deploymentconfigs when tagging images [Conformance] should successfully tag the deployed image Feb 10, 2017
@pweil- pweil- assigned mfojtik and unassigned 0xmichalis Feb 22, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Feb 23, 2017

@pweil- i have no luck reproducing this locally, it seems like the image stream tag is succesfully created, but somehow not listed (maybe it is cached?). I think this is just a test flake as to me this works normally.

So I bumping this back to P2 and will do more investigation in 1.6. Agree?

@smarterclayton smarterclayton modified the milestones: 1.5.0, 1.6.0 Mar 12, 2017
@smarterclayton
Copy link
Contributor

We need to wait for the permissions to be available on the deployer. This is an easy fix (at the beginning of the test, loop until deployer SA can tag images).

openshift-merge-robot added a commit that referenced this issue Aug 1, 2017
Automatic merge from submit-queue (batch tested with PRs 15162, 14901, 15195)

deploy: verify the deployer SA has perms to update tags

fixes: #10663

[test]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests component/apps kind/test-flake Categorizes issue or PR as related to test flakes. priority/P2
Projects
None yet
8 participants