-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant constant definition #11586
Conversation
af9561b
to
0126891
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If @dcbw likes it we should merge it.
LGTM |
[merge] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
flake #10773 |
Evaluated for origin test up to 0126891 |
[merge] |
Evaluated for origin merge up to 0126891 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11078/) (Base Commit: 6abb256) |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11078/) (Base Commit: b68b268) (Image: devenv-rhel7_5309) |
Due to a late-breaking change in the CNI branch we ended up with two copies of AssignMacvlanAnnotation.
@dcbw PTAL
@knobunc 3.4? Low-risk though also low-benefit...