cluster up: use rslave propagation mode with nsenter mounter #10571

csrwng · 2016-08-22T18:41:01Z

When choosing to use nsenter mounter, mount volumes dir with 'rslave' propagation mode

Fixes #10215

csrwng · 2016-08-22T18:41:16Z

@pmorie @ncdc @bparees

csrwng · 2016-08-22T18:41:58Z

I've tested this on RHEL (Docker 1.10) and ArchLinux (Docker 1.12)

bparees · 2016-08-22T19:43:38Z

@csrwng so what, if any, scenarios are broken with this? docker1.9?

csrwng · 2016-08-22T19:44:47Z

@bparees afaik none ... we simply continue using nsenter mounter in most linux distros.

csrwng · 2016-08-22T19:46:53Z

@bparees so the reason that RHEL and Fedora work with nsenter mounter right now is that by default they use 'rslave' propagation mode for all mounts when one is not specified. This is simply forcing other distros to do the same for the volume share.

bparees · 2016-08-22T19:48:26Z

@bparees afaik none ... we simply continue using nsenter mounter in most linux distros.

i feel like @pmorie indicate the slave mount was a new thing in docker1.10.

bparees · 2016-08-22T19:48:57Z

This is simply forcing other distros to do the same for the volume share.

ah, maybe it's that defaulting behavior he was explaining.

pmorie · 2016-08-22T19:50:38Z

i feel like @pmorie indicate the slave mount was a new thing in docker1.10.

The new thing was being able to control the propagation mode of a volume. In the RH distribution of docker prior to 1.9, we carried a patch that made the default propagation mode slave, whereas it was private in upstream.

bparees · 2016-08-22T19:57:38Z

The new thing was being able to control the propagation mode of a volume.

is that not what this PR is taking advantage of?

pmorie · 2016-08-23T14:07:54Z

@bparees to answer your question more clearly -- pre-1.10 non-RH dockers will not work with this.

bparees · 2016-08-23T14:09:12Z

@pmorie thanks. I think we can live w/ that, but i wanted to make sure we understood it.

csrwng · 2016-08-23T14:18:06Z

@bparees @pmorie hmm, actually it won't work on 1.9.x on any OS. I tried on Debian Jessie and Fedora 22, both with 1.9.1:

-- Starting OpenShift container ...
   Creating initial OpenShift configuration
FAIL
   Error: could not create OpenShift configuration
   Caused By:
     Error: cannot create container using image openshift/origin:v1.3.0-alpha.3
     Caused By:
       Error: API error (500): invalid mode for volumes-from: rslave

It seems that maybe we should outright tell you that we need 1.10

csrwng · 2016-08-23T14:19:41Z

Or if running with 1.9, inspect a container to see its mount propagation mode and if 'rslave' then allow you to run.

pmorie · 2016-08-23T14:20:25Z

@csrwng 1.9.x doesn't support the slave flag in any distribution, but in RH, the propagation mode of bind mounts is always slave

csrwng · 2016-08-23T14:24:06Z

nm, in 1.9.1 on fedora, inspecting a container doesn't tell you what the propagation mode is.

csrwng · 2016-08-23T14:52:22Z

@bparees @pmorie so we have 2 options:

Always fail if Docker version < 1.10 and tell you to upgrade
Only add the :rslave mode to the mount if Docker version 1.10 and let you try your luck with Docker version < 1.10 (If on Fedora/RHEL, things will work)

Preference?

pmorie · 2016-08-23T15:01:54Z

I wish there were a way to detect the distro of the docker engine.

bparees · 2016-08-23T15:05:33Z

(2) coupled w/ a warning when you're on docker 1.9 and possibly attempting to detect the distro (/etc/redhat-release) as part of the warning would be my preference i think.

ncdc · 2016-08-23T15:06:07Z

docker info and docker version should be able to get you that info. You
could look at the kernel version, package version, or operating system.

On Tue, Aug 23, 2016 at 11:02 AM, Paul Morie notifications@github.com
wrote:

I wish there were a way to detect the distro of the docker engine.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10571 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAABYlJWHtVU6o1j_ER0bePvR0GXSKMXks5qiwtsgaJpZM4JqLKR
.

csrwng · 2016-08-23T15:09:18Z

Thanks, will take a look... it would definitely be a nicer experience if we tell you outright that we don't support your Docker version

pmorie · 2016-08-23T15:12:35Z

Caveat: what if you run upstream docker on a Red Hat system?

csrwng · 2016-08-23T15:13:53Z

I will try it, and see what's the difference in 'docker info'

bparees · 2016-08-23T15:14:08Z

Caveat: what if you run upstream docker on a Red Hat system?

then hopefully you're running something current :)

yes that's an understood limitation of my suggestion, though it sounds like @ncdc's suggestion would cover it.

pmorie · 2016-08-23T15:16:02Z

then hopefully you're running something current :)

If you're running something current, it doesn't really matter.

bparees · 2016-08-23T15:23:43Z

If you're running something current, it doesn't really matter.

that was my point. if we detect the version is 1.10+, then we don't need to determine the distribution.

So the detection logic would only fail if:

you are on a redhat OS distro
you've installed an upstream distro of docker
that docker version is older than 1.10

which seems unlikely.

csrwng · 2016-08-23T21:20:33Z

Updated the code to check the Docker version. If the Docker version is < 1.10 and not a Red Hat distro, then we fail. Tested on fedora, rhel, arch linux (newer and older docker versions).

bparees · 2016-08-23T21:27:24Z

pkg/bootstrap/docker/dockerhelper/helper.go

-func (h *Helper) Version() (*semver.Version, error) {
+var (
+	fedoraPackage = regexp.MustCompile("\\.fc[0-9_]*\\.")
+	rhelPackage   = regexp.MustCompile("\\.el[0-9_]*\\.")


it also has .el7 (just like rhel):

[root@localhost ~]# docker version Client: Version: 1.10.3 API version: 1.22 Package version: docker-common-1.10.3-46.el7.centos.10.x86_64 Go version: go1.6.3 Git commit: d381c64-unsupported Built: Thu Aug 4 13:21:17 2016 OS/Arch: linux/amd64 Server: Version: 1.10.3 API version: 1.22 Package version: docker-common-1.10.3-46.el7.centos.10.x86_64 Go version: go1.6.3 Git commit: d381c64-unsupported Built: Thu Aug 4 13:21:17 2016 OS/Arch: linux/amd64

bparees · 2016-08-23T21:42:17Z

lgtm, will let @pmorie have the last word.

csrwng · 2016-08-24T00:04:51Z

removed artificial check for mac/windows OS ... we should determine the mount to use based on the docker daemon.

tested on os x and windows

bparees · 2016-08-25T13:32:20Z

@pmorie bump. happy?

pmorie · 2016-08-25T13:42:05Z

lgtm, [merge]

bparees · 2016-08-25T16:16:16Z

Flake #7706

[merge]

Ben Parees | OpenShift

On Aug 25, 2016 12:12 PM, "OpenShift Bot" notifications@github.com wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8432/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10571 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3t5_-S9rk_26EuXyHfZE9IZuEWrKks5qjb7zgaJpZM4JqLKR
.

csrwng · 2016-08-25T18:31:15Z

Flake #7706
[merge]

ncdc · 2016-08-26T00:23:08Z

[merge]

On Thursday, August 25, 2016, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8455/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10571 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAABYsbqlKefYpbYXjAHU8KGVIOhRumhks5qjht_gaJpZM4JqLKR
.

openshift-bot · 2016-08-26T01:52:13Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8464/) (Image: devenv-rhel7_4933)

csrwng · 2016-08-26T02:27:59Z

Flake #9929
[merge]

openshift-bot · 2016-08-26T02:32:17Z

Evaluated for origin merge up to 5630015

csrwng force-pushed the cluster_up_slave_prop_mode branch from 7c56c11 to a3eac5a Compare August 23, 2016 21:08

bparees reviewed Aug 23, 2016
View reviewed changes

cluster up: use rslave propagation mode with nsenter mounter

5630015

csrwng force-pushed the cluster_up_slave_prop_mode branch from a3eac5a to 5630015 Compare August 23, 2016 23:11

openshift-bot merged commit d89bdf3 into openshift:master Aug 26, 2016

csrwng mentioned this pull request Sep 8, 2016

cluster up: error: cannot connect to the server: open /var/run/secrets/kubernetes.io/serviceaccount/token: no such file or directory #10838

Closed

pweil- mentioned this pull request Dec 9, 2016

add rslave propagation mode for volume mounts openshift/openshift-docs#3356

Merged

csrwng deleted the cluster_up_slave_prop_mode branch December 21, 2016 20:58

cluster up: use rslave propagation mode with nsenter mounter #10571

cluster up: use rslave propagation mode with nsenter mounter #10571

Conversation

csrwng commented Aug 22, 2016

csrwng commented Aug 22, 2016

csrwng commented Aug 22, 2016

bparees commented Aug 22, 2016

csrwng commented Aug 22, 2016

csrwng commented Aug 22, 2016

bparees commented Aug 22, 2016

bparees commented Aug 22, 2016

pmorie commented Aug 22, 2016

bparees commented Aug 22, 2016

pmorie commented Aug 23, 2016

bparees commented Aug 23, 2016

csrwng commented Aug 23, 2016

csrwng commented Aug 23, 2016

pmorie commented Aug 23, 2016 • edited Loading

csrwng commented Aug 23, 2016

csrwng commented Aug 23, 2016

pmorie commented Aug 23, 2016

bparees commented Aug 23, 2016

ncdc commented Aug 23, 2016

csrwng commented Aug 23, 2016

pmorie commented Aug 23, 2016

csrwng commented Aug 23, 2016

bparees commented Aug 23, 2016

pmorie commented Aug 23, 2016

bparees commented Aug 23, 2016

csrwng commented Aug 23, 2016

bparees Aug 23, 2016

Choose a reason for hiding this comment

csrwng Aug 23, 2016

Choose a reason for hiding this comment

bparees Aug 23, 2016

Choose a reason for hiding this comment

bparees commented Aug 23, 2016

csrwng commented Aug 24, 2016

bparees commented Aug 25, 2016

pmorie commented Aug 25, 2016

bparees commented Aug 25, 2016

csrwng commented Aug 25, 2016

ncdc commented Aug 26, 2016

openshift-bot commented Aug 26, 2016 • edited Loading

csrwng commented Aug 26, 2016

openshift-bot commented Aug 26, 2016

pmorie commented Aug 23, 2016 •

edited

Loading

openshift-bot commented Aug 26, 2016 •

edited

Loading