-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images on DockerHub fail to import size because they are in schema1 #7706
Comments
Not related to #8558 - will need a separate fix. |
https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_integration/1357/consoleFull
Been hitting this all day today |
We should stop using DockerHub in our tests. |
Seeing similar (??) failures on recent runs ... moving to P0 as the last 20 test_integration runs have failed on it.
|
Not all tests can run disconnected from DockerHub. Being able to inter-operate with DockerHub is one of our core use-cases, so we will always end up having some level of test dependency on them and given how critical the path is, I think its reasonable to block merge on them. I'm not against trying to make it more resilient to transient failures, but I'm far less inclined to remove the dependency entirely. Imagine if we had a new-app bug that prevented it from working against the docker hub. |
Looks like the reported image size is wrong. Check to see if dockerhub stopped reporting the field. |
@deads2k we can consolidate the tests we need to run against DockerHub. Also, it would be nice if we wouldn't run those tests, when pulls don't affect things we need to work against DockerHub AND DockerHub is down at the same time. |
Kind of the whole point of running the full suite always is that the program is incredibly complex and we can't reason about how any one change could fan out to the rest of the software, so I don't think it's ideologically sound to say that we can, for any pull, determine if it has no chance of affecting image import. |
DockerHub switched from schema 1 to schema 2 today, @miminar |
We use v1Compatibility to calculate size of each layer: https://github.com/openshift/origin/blob/master/pkg/image/api/helper.go#L366-L373 but I think Size is no longer there: That's why we have layers, but their size is zero as the size of the metadata. |
Can we patch quickly to work with v2 for Size, or do we need to wait for the 2.4 registry update? |
We can't change the manifest, because it will change the digest of manifest.
This update doesn't help because schema v1 is affected. We need to calculate the Size in different way. In same way as dockerregistry does: |
I guess I can fix it. |
That's what I'm referring to - calculating size differently on import by On Wed, Jun 1, 2016 at 11:21 AM, Alexey Gladkov notifications@github.com
|
Can I get a commit from someone to either put a fix in or work around this by 2pm EDT? I'm ok with disabling the test condition that's failing as long as someone is committed to a fix. This is something we may have to backport to 1.2.0 and earlier so that people can actually use us. |
@legionus has a fix locally |
Thanks, please keep this issue updated and be sure to notify people on the On Wed, Jun 1, 2016 at 12:31 PM, Michail Kargakis notifications@github.com
|
For 1.3 we need to make the transition to schema2 (well under way) and then be sure we import the new size. |
@smarterclayton I'm not sure I understand. |
We need to be sure that we import via schema2 by default, and fall back to schema1 only if necessary. |
Summary:
|
I've seen this in 5 of the last 6 test runs, the sixth failed on yum. Bumping to P1. |
They updated pulp to v2 today, fixing the bug. We need to fix the test
|
https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5142/consoleFull
The text was updated successfully, but these errors were encountered: