Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oc: inform about switch to the same project #8979

Merged
merged 1 commit into from
Jun 3, 2016
Merged

oc: inform about switch to the same project #8979

merged 1 commit into from
Jun 3, 2016

Conversation

0xmichalis
Copy link
Contributor

@deads2k PTAL

@mfojtik
Copy link
Contributor

mfojtik commented May 23, 2016

LGTM

@deads2k
Copy link
Contributor

deads2k commented May 23, 2016

Why is the distinction valuable? I see the command as declarative, not imperative, and the end result is identical.

@0xmichalis
Copy link
Contributor Author

@deads2k this mimics git checkout. End result is the same but UX is slightly better?

cc: @fabianofranz

@deads2k
Copy link
Contributor

deads2k commented May 23, 2016

Code looks fine. I'll leave the UI decision up to @fabianofranz .

@fabianofranz
Copy link
Member

LGTM [merge]

@0xmichalis
Copy link
Contributor Author

#9089 flake

[merge]

@0xmichalis
Copy link
Contributor Author

same flake, re[merge]

@0xmichalis
Copy link
Contributor Author

[merge]

@deads2k
Copy link
Contributor

deads2k commented May 31, 2016

flake fixed [merge]

@0xmichalis
Copy link
Contributor Author

[merge]

@0xmichalis
Copy link
Contributor Author

#7706 flaked

[merge]

@0xmichalis
Copy link
Contributor Author

[merge]

@fabianofranz
Copy link
Member

srsly [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 2, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4397/) (Image: devenv-rhel7_4305)

@0xmichalis
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 30e31cf

@openshift-bot openshift-bot merged commit 9089acc into openshift:master Jun 3, 2016
@0xmichalis 0xmichalis deleted the oc-project-fix branch June 3, 2016 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabianofranz fabianofranz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xmichalis @mfojtik @deads2k @fabianofranz @openshift-bot