Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable auto-fixing for ruff in pre-commit #1004

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Apr 6, 2023

Description

  • Enable auto-fixing for ruff

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@@ -25,6 +25,7 @@ repos:
hooks:
- id: ruff
exclude: "tests"
args: ["--fix"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this still fail the PR if the files are not formatted correctly? Current use run pre-commit within tox. And, the tox environment is used in pre_merge checks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. How did it work with isort?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Forgot about this. I tried it locally. Should fail the CI even with fix. Let's merge this.

@ashwinvaidya17
Copy link
Collaborator

Codecov upload has failed but the tests have passed.

@samet-akcay
Copy link
Contributor

Codecov upload has failed but the tests have passed.

Yeah, let's merge this

@samet-akcay samet-akcay merged commit 3b00ecf into openvinotoolkit:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants