Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable auto-fixing for ruff in pre-commit #1004

Merged
merged 1 commit into from
Apr 19, 2023
Merged

enable auto-fixing for ruff in pre-commit #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ repos:
hooks:
- id: ruff
exclude: "tests"
args: ["--fix"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this still fail the PR if the files are not formatted correctly? Current use run pre-commit within tox. And, the tox environment is used in pre_merge checks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. How did it work with isort?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Forgot about this. I tried it locally. Should fail the CI even with fix. Let's merge this.


# python static type checking
- repo: https://github.com/pre-commit/mirrors-mypy
Expand Down