-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pipelines] π¨ Intra-stage result passing #2061
Merged
ashwinvaidya17
merged 20 commits into
openvinotoolkit:feature/pipelines
from
ashwinvaidya17:design/intra_stage_results
May 15, 2024
Merged
[Pipelines] π¨ Intra-stage result passing #2061
ashwinvaidya17
merged 20 commits into
openvinotoolkit:feature/pipelines
from
ashwinvaidya17:design/intra_stage_results
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
β¦/intra_stage_results
@blaz-r here is my proposal for passing data between stages |
Yeah, this looks great. I think this would now cover everything that a pipeline should offer. |
samet-akcay
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
ashwinvaidya17
merged commit May 15, 2024
3de51a4
into
openvinotoolkit:feature/pipelines
7 checks passed
ashwinvaidya17
added a commit
that referenced
this pull request
May 24, 2024
* π Anomalib Pipelines (#2005) * Add initial design Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Refactor + add to CLI Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Support grid search on class path Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * redirect outputs Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * design v2 Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * remove commented code Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * add dummy experiment Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * add config Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Refactor Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Add tests Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Apply suggestions from code review Co-authored-by: Samet Akcay <samet.akcay@intel.com> * address pr comments Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Apply suggestions from code review Co-authored-by: Samet Akcay <samet.akcay@intel.com> * refactor Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Simplify argparse Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * modify logger redirect Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * update docstrings Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> --------- Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> Co-authored-by: Samet Akcay <samet.akcay@intel.com> * π Fix Rich Progress with Patchcore Training (#2062) Add safe track Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * [Pipelines] π¨ Intra-stage result passing (#2061) * Add initial design Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Refactor + add to CLI Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Support grid search on class path Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * redirect outputs Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * design v2 Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * remove commented code Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * add dummy experiment Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * add config Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Refactor Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Add tests Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Apply suggestions from code review Co-authored-by: Samet Akcay <samet.akcay@intel.com> * address pr comments Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Apply suggestions from code review Co-authored-by: Samet Akcay <samet.akcay@intel.com> * refactor Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Simplify argparse Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * modify logger redirect Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * update docstrings Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Add proposal Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> --------- Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> Co-authored-by: Samet Akcay <samet.akcay@intel.com> * Update src/anomalib/pipelines/benchmark/job.py --------- Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
β¨ Changes
Select what type of change your PR is:
β Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.