🐞 Fix Rich Progress with Patchcore Training #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
ashwinvaidya17
commented
May 15, 2024
| @@ -406,7 +406,7 @@ def _setup_transform( | |||
|
|
|||
| def _setup_anomalib_callbacks(self) -> None: | |||
| """Set up callbacks for the trainer.""" | |||
| _callbacks: list[Callback] = [] | |||
| _callbacks: list[Callback] = [RichProgressBar(), RichModelSummary()] | |||
There was a problem hiding this comment.
This change is not directly related to the bug but I am now using RichProgressBar in the trainer. I don't mind if we drop this as it is not necessary
|
@blaz-r I can't reproduce the error with Padim but maybe the fix in this PR might work for you. |
samet-akcay
approved these changes
May 15, 2024
|
I'll check it out now. |
|
I tried to run it on ubuntu through wsl and on windows directly. While I didn't manage to get it working on ubuntu, It work on windows now. The only problem is with filename, that is not valid on windows. I left a comment with a suggestion on how it can be addressed on #2060 . |
|
What's the error on ubuntu? |
|
Same as before, I think it's a wsl, not an ubuntu problem but I'm not sure. |
|
Alright in that case I'll merge it as is as I am using Ubuntu and I can't reproduce it. We can always revisit this in-case more people face this issue. |
|
Okay |
ashwinvaidya17
merged commit 849de79
into
openvinotoolkit:feature/pipelines
5 of 7 checks passed
ashwinvaidya17
added a commit
that referenced
this pull request
May 24, 2024
* 🚀 Anomalib Pipelines (#2005) * Add initial design Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Refactor + add to CLI Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Support grid search on class path Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * redirect outputs Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * design v2 Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * remove commented code Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * add dummy experiment Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * add config Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Refactor Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Add tests Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Apply suggestions from code review Co-authored-by: Samet Akcay <samet.akcay@intel.com> * address pr comments Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Apply suggestions from code review Co-authored-by: Samet Akcay <samet.akcay@intel.com> * refactor Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Simplify argparse Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * modify logger redirect Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * update docstrings Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> --------- Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> Co-authored-by: Samet Akcay <samet.akcay@intel.com> * 🐞 Fix Rich Progress with Patchcore Training (#2062) Add safe track Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * [Pipelines] 🔨 Intra-stage result passing (#2061) * Add initial design Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Refactor + add to CLI Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Support grid search on class path Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * redirect outputs Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * design v2 Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * remove commented code Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * add dummy experiment Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * add config Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Refactor Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Add tests Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Apply suggestions from code review Co-authored-by: Samet Akcay <samet.akcay@intel.com> * address pr comments Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Apply suggestions from code review Co-authored-by: Samet Akcay <samet.akcay@intel.com> * refactor Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Simplify argparse Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * modify logger redirect Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * update docstrings Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Add proposal Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> --------- Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> Co-authored-by: Samet Akcay <samet.akcay@intel.com> * Update src/anomalib/pipelines/benchmark/job.py --------- Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
trackfromrich, it breaks when we use any other progress bar. This caches theLiveDisplaybefore usingtrackin subsampling.✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.