Skip to content

Commit

Permalink
Serialize Polyhedral Objects over Oscar fields (#3386)
Browse files Browse the repository at this point in the history
* some progress on serializing dicts

* saving

* serialization: add helpers to deconstruct polymake bigobject to dict

currently with a few warnings that might be removed later

* updates

* starting on load

* fix type string for saving

* adds work around for vector{Int}

* use new qualified bigobject name

* serialize dicts

* still need to work out loading

* can load polyhedral object over different fields

* some updates

* add helpers for conversion from oscar graphs back to polymake

* tiny improvement

* fix inner types, store coeff only once

* polymake: improve matrix conversion helpers, allow float in some places

* adds serialzation for sets

* adds test for dicts

* adds test for sets

* replace johnson matrices with Johnson solids

* replace johnson matrices with solids

* pretty print the rest of the Johnson Solids

* pretty print

* padding, + file extension and not pretty printed

* fixes polyhedral test

* update file version tag

* file version tag + add extension for surface files

* fix surface loading

* fix typo

* adds fix for polyhedron of floats and adds test

* fix typo

* better padding implementation

* adds catch for unsupported loading types

* remove Nothing type for coeff inputs, and fixed vector collect

* adds tests for serializing polyhdral objects over oscar fields

* fixes to MILP

* MILP: add missing specialization for QQ to avoid saving other fields for now

* polymake: change warnings to debug when saving unsupported polymake properties

* polyhedral: add missing field for loading milp

* fix for polyhedron with floats

* serialization: fix load distinction between different fields, fix loading float polytopes

* Update test/Serialization/PolyhedralGeometry.jl

* Apply suggestions from code review

Co-authored-by: Lars Kastner <lkastner@users.noreply.github.com>

---------

Co-authored-by: Benjamin Lorenz <lorenz@math.tu-berlin.de>
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Co-authored-by: Lars Kastner <lkastner@users.noreply.github.com>
  • Loading branch information
4 people committed Feb 22, 2024
1 parent 290734f commit 52c1236
Show file tree
Hide file tree
Showing 236 changed files with 569 additions and 236 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ JSON3 = "1.13.2"
LazyArtifacts = "1.6"
Nemo = "0.43.0"
Pkg = "1.6"
Polymake = "0.11.13"
Polymake = "0.11.14"
Preferences = "1"
Random = "1.6"
RandomExtensions = "0.4.3"
Expand Down
1 change: 0 additions & 1 deletion data/JohnsonMatrices/j10.mat

This file was deleted.

1 change: 0 additions & 1 deletion data/JohnsonMatrices/j13.mat

This file was deleted.

1 change: 0 additions & 1 deletion data/JohnsonMatrices/j16.mat

This file was deleted.

1 change: 0 additions & 1 deletion data/JohnsonMatrices/j17.mat

This file was deleted.

1 change: 0 additions & 1 deletion data/JohnsonMatrices/j18.mat

This file was deleted.

1 change: 0 additions & 1 deletion data/JohnsonMatrices/j20.mat

This file was deleted.

1 change: 0 additions & 1 deletion data/JohnsonMatrices/j21.mat

This file was deleted.

Loading

0 comments on commit 52c1236

Please sign in to comment.