Serialize Polyhedral Objects over Oscar fields #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently with a few warnings that might be removed later
antonydellavecchia
added
serialization
backport 1.0.x
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3386 +/- ##
==========================================
- Coverage 82.10% 81.87% -0.24%
==========================================
Files 557 560 +3
Lines 73971 75034 +1063
==========================================
+ Hits 60734 61434 +700
- Misses 13237 13600 +363
|
antonydellavecchia
changed the title
…ding float polytopes
benlorenz
reviewed
Feb 22, 2024
lkastner
approved these changes
Feb 22, 2024
Co-authored-by: Lars Kastner <lkastner@users.noreply.github.com>
benlorenz
pushed a commit
that referenced
this pull request
Feb 23, 2024
* some progress on serializing dicts
* saving
* serialization: add helpers to deconstruct polymake bigobject to dict
currently with a few warnings that might be removed later
* updates
* starting on load
* fix type string for saving
* adds work around for vector{Int}
* use new qualified bigobject name
* serialize dicts
* still need to work out loading
* can load polyhedral object over different fields
* some updates
* add helpers for conversion from oscar graphs back to polymake
* tiny improvement
* fix inner types, store coeff only once
* polymake: improve matrix conversion helpers, allow float in some places
* adds serialzation for sets
* adds test for dicts
* adds test for sets
* replace johnson matrices with Johnson solids
* replace johnson matrices with solids
* pretty print the rest of the Johnson Solids
* pretty print
* padding, + file extension and not pretty printed
* fixes polyhedral test
* update file version tag
* file version tag + add extension for surface files
* fix surface loading
* fix typo
* adds fix for polyhedron of floats and adds test
* fix typo
* better padding implementation
* adds catch for unsupported loading types
* remove Nothing type for coeff inputs, and fixed vector collect
* adds tests for serializing polyhdral objects over oscar fields
* fixes to MILP
* MILP: add missing specialization for QQ to avoid saving other fields for now
* polymake: change warnings to debug when saving unsupported polymake properties
* polyhedral: add missing field for loading milp
* fix for polyhedron with floats
* serialization: fix load distinction between different fields, fix loading float polytopes
* Update test/Serialization/PolyhedralGeometry.jl
* Apply suggestions from code review
Co-authored-by: Lars Kastner <lkastner@users.noreply.github.com>
---------
Co-authored-by: Benjamin Lorenz <lorenz@math.tu-berlin.de>
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Co-authored-by: Lars Kastner <lkastner@users.noreply.github.com>
(cherry picked from commit 52c1236)
benlorenz
removed
the
backport 1.0.x
benlorenz
added a commit
that referenced
this pull request
Feb 23, 2024
### Backported PRs - [x] #3367 - [x] #3379 - [x] #3369 - [x] #3291 - [x] #3325 - [x] #3350 - [x] #3351 - [x] #3365 - [x] #3366 - [x] #3382 - [x] #3373 - [x] #3341 - [x] #3346 - [x] #3381 - [x] #3385 - [x] #3387 - [x] #3398 - [x] #3399 - [x] #3374 - [x] #3406 - [x] #2823 - [x] #3298 - [x] #3386 - [x] #3412 - [x] #3392 - [x] #3415 - [x] #3394 - [x] #3391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds serialization fo Polyhedral objects over fields available in Oscar and for Dicts and Sets .
adjusts the Johnson Solids so they are no longer loading from matrices