Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded GAP package sla #3398

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

lgoettgens
Copy link
Member

When reading through #3395, I noticed that sla has been added in #2572, but I don't think it is used anywhere anymore (e.g. as #2572 has been majorly refactored in #2689).

@lgoettgens lgoettgens marked this pull request as ready for review February 20, 2024 10:53
@lgoettgens lgoettgens added the backport 1.0.x Should be backported to the release 1.0 branch label Feb 20, 2024
@aaruni96 aaruni96 mentioned this pull request Feb 20, 2024
33 tasks
Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
The relevant GAP code (for example in cartan_matrix) has been reimplemented in Julia.
Good.

@fingolfin fingolfin merged commit 0bc8558 into oscar-system:master Feb 20, 2024
20 checks passed
@lgoettgens lgoettgens deleted the lg/sla branch February 20, 2024 20:50
benlorenz pushed a commit that referenced this pull request Feb 21, 2024
(cherry picked from commit 0bc8558)
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Feb 21, 2024
benlorenz added a commit that referenced this pull request Feb 23, 2024
### Backported PRs

- [x] #3367
- [x] #3379 
- [x] #3369
- [x] #3291
- [x] #3325
- [x] #3350 
- [x] #3351
- [x] #3365 
- [x] #3366
- [x] #3382
- [x] #3373
- [x] #3341
- [x] #3346
- [x] #3381
- [x] #3385
- [x] #3387 
- [x] #3398 
- [x] #3399 
- [x] #3374 
- [x] #3406 
- [x] #2823
- [x] #3298
- [x] #3386 
- [x] #3412 
- [x] #3392 
- [x] #3415 
- [x] #3394
- [x] #3391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants