Corrected defn of deg(ideal); correction from W Decker #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdecker
approved these changes
Feb 22, 2024
|
Some tests for all these three issues would have been nice. |
|
I will add a relevant test example tomorrow. |
benlorenz
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Corrected defn of deg(ideal); correction from W Decker * Removed spaces at end of lines (to force GitHub to try again) (cherry picked from commit 290734f)
benlorenz
removed
the
backport 1.0.x
wdecker
added a commit
that referenced
this pull request
Feb 23, 2024
benlorenz
added a commit
that referenced
this pull request
Feb 23, 2024
### Backported PRs - [x] #3367 - [x] #3379 - [x] #3369 - [x] #3291 - [x] #3325 - [x] #3350 - [x] #3351 - [x] #3365 - [x] #3366 - [x] #3382 - [x] #3373 - [x] #3341 - [x] #3346 - [x] #3381 - [x] #3385 - [x] #3387 - [x] #3398 - [x] #3399 - [x] #3374 - [x] #3406 - [x] #2823 - [x] #3298 - [x] #3386 - [x] #3412 - [x] #3392 - [x] #3415 - [x] #3394 - [x] #3391
wdecker
added a commit
that referenced
this pull request
Feb 26, 2024
fieker
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Add test example to PR #3412 as requested by @thofma * docu invariants tori * readd algebraic.md * typo * Update docs/doc.main * add one more functions and corrections * correction * correction * addressing review * forgot to add corrected file --------- Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
benlorenz
pushed a commit
that referenced
this pull request
Feb 28, 2024
* Add test example to PR #3412 as requested by @thofma * docu invariants tori * readd algebraic.md * typo * Update docs/doc.main * add one more functions and corrections * correction * correction * addressing review * forgot to add corrected file --------- Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de> (cherry picked from commit 3c5f7fe)
mjrodgers
pushed a commit
to mjrodgers/Oscar.jl
that referenced
this pull request
Feb 28, 2024
* Add test example to PR oscar-system#3412 as requested by @thofma * docu invariants tori * readd algebraic.md * typo * Update docs/doc.main * add one more functions and corrections * correction * correction * addressing review * forgot to add corrected file --------- Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two corrections:
ZZRingElem(previouslyInt)