Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable duvalsing tests #2638

Closed
ederc opened this issue Aug 7, 2023 · 4 comments · Fixed by #2776
Closed

Reenable duvalsing tests #2638

ederc opened this issue Aug 7, 2023 · 4 comments · Fixed by #2776
Assignees
@ederc
Labels
bug Something isn't working

Comments

@ederc
Copy link
Member

ederc commented Aug 7, 2023 •
edited by lgoettgens
Loading

We removed duvalsing tests in #2637 due to problems with absolute factorization. These tests need to be reenabled at some point.
@ederc ederc added the bug Something isn't working label Aug 7, 2023
@ederc ederc changed the title Reintroduce duvalsing tests Reenable duvalsing tests Aug 7, 2023
@ederc ederc changed the title Reenable duvalsing tests Reenable duvalsing and FTheory tests Aug 8, 2023
@ederc
Copy link
Member Author

ederc commented Aug 8, 2023

We also had to disable FTheory tests, thus the same holds for them.
@HereAround

@lgoettgens
Copy link
Member

We also had to disable FTheory tests, thus the same holds for them. @HereAround

The FTheory tests have already been enabled again in #2640.

@lgoettgens lgoettgens changed the title Reenable duvalsing and FTheory tests Reenable duvalsing tests Aug 10, 2023
@HereAround
Copy link
Member

We also had to disable FTheory tests, thus the same holds for them. @HereAround

The FTheory tests have already been enabled again in #2640.

This is on purpose as @lkastner fixed the problem.

@fingolfin
Copy link
Member

@ederc this might be resolved now, can you try re-enabling it (via a PR)?

@ederc ederc mentioned this issue Sep 6, 2023
Merged
@lgoettgens lgoettgens linked a pull request Sep 6, 2023 that will close this issue
Reenables duvalsing tests #2776
Merged
YueRen added a commit that referenced this issue Aug 13, 2024
@YueRen
TropicalGeometry: removed warning after fixed bug (issue #2638)
cf6c70b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ederc ederc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reenables duvalsing tests ederc/Oscar.jl
4 participants
@fingolfin @ederc @HereAround @lgoettgens