Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor triangulation bug #2640

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Fix minor triangulation bug #2640

merged 6 commits into from
Aug 8, 2023

Conversation

lkastner
Copy link
Member

@lkastner lkastner commented Aug 8, 2023

No description provided.

@lkastner lkastner added bug Something isn't working topic: polyhedral geometry Issue concerns polyhedral geometry code topic: FTheoryTools labels Aug 8, 2023
HereAround
HereAround approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@HereAround HereAround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lkastner . Great!

@ederc these changes should fix the FTheory tests.

@lkastner lkastner enabled auto-merge August 8, 2023 16:57
@lkastner lkastner merged commit 87a9df5 into master Aug 8, 2023
9 of 12 checks passed
@lkastner lkastner deleted the lk/ftheory/fix_star branch August 8, 2023 22:37
@lgoettgens lgoettgens mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HereAround HereAround HereAround approved these changes

Assignees
No one assigned
Labels
bug Something isn't working topic: FTheoryTools topic: polyhedral geometry Issue concerns polyhedral geometry code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkastner @HereAround