Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename files according to styleguide #2354

Merged
merged 3 commits into from
May 9, 2023
Merged

Rename files according to styleguide #2354

merged 3 commits into from
May 9, 2023

Conversation

lkastner
Copy link
Member

@lkastner lkastner commented May 8, 2023

Not everywhere, but in the more obvious places.

@lkastner lkastner added enhancement New feature or request WIP NOT ready for merging renaming labels May 8, 2023
Copy link
Member

@benlorenz benlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #2354 (41a3f1a) into master (88ef91f) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2354   +/-   ##
=======================================
  Coverage   71.63%   71.63%           
=======================================
  Files         377      377           
  Lines       52478    52478           
=======================================
+ Hits        37592    37595    +3     
+ Misses      14886    14883    -3     
Impacted Files Coverage Δ
src/Oscar.jl 14.83% <ø> (ø)
src/PolyhedralGeometry/LP_file_format.jl 96.15% <ø> (ø)
src/PolyhedralGeometry/PolyhedralGeometry.jl 25.00% <ø> (ø)
src/PolyhedralGeometry/groups.jl 84.81% <ø> (ø)
src/PolyhedralGeometry/linear_program.jl 60.78% <ø> (ø)
...PolyhedralGeometry/mixed_integer_linear_program.jl 56.66% <ø> (ø)
src/PolyhedralGeometry/visualization.jl 0.00% <ø> (ø)
src/deprecations.jl 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

@lkastner lkastner marked this pull request as ready for review May 9, 2023 06:44
@lkastner lkastner merged commit 708ce15 into master May 9, 2023
@lkastner lkastner deleted the lk/rename_files branch May 9, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request renaming WIP NOT ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants