Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename files according to styleguide #2354

Merged
merged 3 commits into from
May 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/src/DeveloperDocumentation/styleguide.md
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ printing in Oscar](@ref).

Sometimes it is necessary to rename a function or otherwise change it. To allow
for backwards compatibility, please then introduce a new line in the file
`src/Deprecations.jl`. The syntax is as follows:
`src/deprecations.jl`. The syntax is as follows:
```
# Deprecated after CURRENT_RELEASE_VERSION
@deprecate old_function(args) new_function(args)
Expand All @@ -280,14 +280,14 @@ end
@deprecate old_function(args) new_function(transform_args_for_new_function(args))
```
The comment about the version number is only necessary if you are the first one
adding to `Deprecations.jl` after a release, otherwise please add to the
adding to `deprecations.jl` after a release, otherwise please add to the
existing block.

!!! note
Please make sure to change to the new function everywhere in the existing
OSCAR code base. Even if you think, you were the only one using the
function, run a quick `grep` to make sure. When you are done,
`Deprecations.jl` should be the only place mentioning `old_function`. To
`deprecations.jl` should be the only place mentioning `old_function`. To
make sure, you can start Julia with `--depwarn=yes` or even
`--depwarn=error` and then run the tests.

Expand Down
8 changes: 4 additions & 4 deletions src/Oscar.jl
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ function test_experimental_module(
test_module(test_file; new)
end

include("Exports.jl")
include("exports.jl")

# HACK/FIXME: remove these aliases once we have them in AA/Nemo/Hecke
@alias characteristic_polynomial charpoly # FIXME
Expand Down Expand Up @@ -549,7 +549,7 @@ include("Rings/ReesAlgebra.jl")

include("NumberTheory/NmbThy.jl")

include("PolyhedralGeometry/main.jl")
include("PolyhedralGeometry/PolyhedralGeometry.jl")

include("Polymake/polymake_to_oscar.jl")

Expand Down Expand Up @@ -587,9 +587,9 @@ end

include("Serialization/main.jl")

include("Aliases.jl")
include("aliases.jl")

include("Deprecations.jl")
include("deprecations.jl")

const global OSCAR = Oscar
const global oscar = Oscar
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ include("PolyhedralComplex/standard_constructions.jl")
include("SubdivisionOfPoints/constructors.jl")
include("SubdivisionOfPoints/properties.jl")
include("SubdivisionOfPoints/functions.jl")
include("LinearProgram.jl")
include("MixedIntegerLinearProgram.jl")
include("LPFiles.jl")
include("Groups.jl")
include("linear_program.jl")
include("mixed_integer_linear_program.jl")
include("LP_file_format.jl")
include("groups.jl")
include("type_functions.jl")
include("Visualization.jl")
include("visualization.jl")
include("solving_integrally.jl")
include("triangulations.jl")

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
14 changes: 7 additions & 7 deletions test/PolyhedralGeometry/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ using Oscar

include("types.jl")
include("iterators.jl")
include("Cone.jl")
include("Group.jl")
include("Polyhedron.jl")
include("LinearProgram.jl")
include("PolyhedralFan.jl")
include("PolyhedralComplex.jl")
include("SubdivisionOfPoints.jl")
include("cone.jl")
include("group.jl")
include("polyhedron.jl")
include("linear_program.jl")
include("polyhedral_fan.jl")
include("polyhedral_complex.jl")
include("subdivision_of_points.jl")
include("extended.jl")
include("timing.jl")
include("solve_integrally.jl")
Expand Down