Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jacobi_matrix to jacobian_matrix #3180

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

paemurru
Copy link
Contributor

The correct spelling in English is "Jacobian matrix", "Jacobian ideal" and "Jacobi symbol".

Added deprecations:

Deprecated after 0.15.0

Base.@deprecate_binding jacobi_matrix jacobian_matrix
Base.@deprecate_binding jacobi_ideal jacobian_ideal

paemurru and others added 3 commits January 12, 2024 11:43
The correct spelling in English is "Jacobian matrix", "Jacobian ideal"
and "Jacobi symbol".

Base.@deprecate_binding jacobi_matrix jacobian_matrix
Base.@deprecate_binding jacobi_ideal jacobian_ideal
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Merging #3180 (1c62750) into master (673924c) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is 89.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3180   +/-   ##
=======================================
  Coverage   81.14%   81.14%           
=======================================
  Files         556      556           
  Lines       73894    73894           
=======================================
  Hits        59963    59963           
  Misses      13931    13931           
Files Coverage Δ
experimental/PlaneCurve/src/PlaneCurve.jl 83.51% <100.00%> (ø)
experimental/PlaneCurve/src/ProjCurve.jl 69.38% <100.00%> (ø)
experimental/PlaneCurve/src/ProjEllipticCurve.jl 76.14% <100.00%> (ø)
experimental/PlaneCurve/src/ProjPlaneCurve.jl 87.83% <100.00%> (ø)
experimental/PlaneCurve/test/runtests.jl 100.00% <ø> (ø)
experimental/Schemes/CoveredProjectiveSchemes.jl 81.31% <ø> (ø)
experimental/Schemes/IdealSheaves.jl 88.73% <ø> (ø)
experimental/Schemes/duValSing.jl 100.00% <100.00%> (ø)
...braicGeometry/RationalPoint/AffineRationalPoint.jl 79.31% <100.00%> (ø)
...ometry/Schemes/AffineSchemes/Objects/Attributes.jl 88.34% <100.00%> (ø)
... and 10 more

Copy link
Collaborator

@simonbrandhorst simonbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

@simonbrandhorst simonbrandhorst merged commit a047b2d into oscar-system:master Jan 15, 2024
25 checks passed
@paemurru paemurru deleted the EP/RenameJacobian branch January 19, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants