Add some more functionality, docs and tests for root systems #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/root-system-stuff
branch
from
f45a0fc
to
00ff8d5
Compare
|
Please add a property test to make sure that the roots of the dual root system correspond to the coroots of the base root system. |
fingolfin
reviewed
Jan 17, 2024
| Returns the `i`-th coroot of `R`, i.e. the `i`-th root of the dual root system of `R`. | ||
| This is a more efficient version for `coroots(R)[i]`. | ||
|
|
||
| Also see: `coroots`. |
There was a problem hiding this comment.
How about using an actual ref?
Suggested change
| Also see: `coroots`. | |
| Also see: [`coroots`](@ref). |
There was a problem hiding this comment.
This does only work once we have a markdown page collecting the docstrings. That's something @felix-roehrich wants to approach in the near future.
done |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3191 +/- ##
========================================
Coverage 81.27% 81.27%
========================================
Files 556 557 +1
Lines 74019 74133 +114
========================================
+ Hits 60158 60253 +95
- Misses 13861 13880 +19
|
Co-authored-by: Felix Röhrich <47457568+felix-roehrich@users.noreply.github.com>
lgoettgens
commented
Jan 18, 2024
lgoettgens
commented
Jan 18, 2024
felix-roehrich
approved these changes
Jan 18, 2024
|
can we get a merge of this? maybe @thofma ? |
thofma
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.