Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more functionality, docs and tests for root systems #3191

Merged
merged 11 commits into from
Jan 23, 2024
Merged

Add some more functionality, docs and tests for root systems #3191

merged 11 commits into from
Jan 23, 2024

Commits on Jan 16, 2024

  1. Add some docs and tests for root systems

    @lgoettgens
    lgoettgens committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    3b841f5 View commit details
    Browse the repository at this point in the history

  2. Sort roots by height

    @lgoettgens
    lgoettgens committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ad1e92a View commit details
    Browse the repository at this point in the history

  3. Some changes to RootSystem

    @lgoettgens
    lgoettgens committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    3df5c93 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @lgoettgens
    lgoettgens committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a195ed7 View commit details
    Browse the repository at this point in the history

  5. Add dual for root systems

    @lgoettgens
    lgoettgens committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    0f941f6 View commit details
    Browse the repository at this point in the history

  6. Use more accessors

    @lgoettgens
    lgoettgens committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    00ff8d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Overhaul dual roots

    @lgoettgens
    lgoettgens committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7a732f7 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Felix Röhrich <47457568+felix-roehrich@users.noreply.github.com>
    @lgoettgens @felix-roehrich
    lgoettgens and felix-roehrich committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    113289a View commit details
    Browse the repository at this point in the history

  3. Fix bilinear_form

    @lgoettgens
    lgoettgens committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    48f625a View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @lgoettgens
    lgoettgens committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c59642a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into lg/root-system-stuff

    @lgoettgens
    lgoettgens committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    f0e36cd View commit details
    Browse the repository at this point in the history