Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not show the OscarInterface banner #3422

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

ThomasBreuer
Copy link
Member

The banner can be switched off by calling GAP.Globals.LoadPackage with second argument false.
(We cannot call GAP.load because OscarInterface is outside the GAP root paths.)

The question is rather why using Oscar did not show the banner before this change.

resolves #3414

@lgoettgens lgoettgens added package: GAP backport 1.0.x Should be backported to the release 1.0 branch labels Feb 23, 2024
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this indeed fixes the issue described in #3414.

@ThomasBreuer
Copy link
Member Author

The Invalidations test fails.
How can this change increase the number of invalidations?

@thofma
Copy link
Collaborator

thofma commented Feb 23, 2024

(You just have to restart it often enough until it passes.)

@ThomasBreuer ThomasBreuer merged commit 5f86803 into oscar-system:master Feb 23, 2024
20 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_no_GAP_banner branch February 23, 2024 21:59
@benlorenz benlorenz mentioned this pull request Feb 26, 2024
31 tasks
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Feb 26, 2024
benlorenz added a commit that referenced this pull request Feb 29, 2024
- Add QQBar docs to the manual #3423
- do not show the OscarInterface banner #3422
- fix bugs in all_OD_infos #3419
- Ep/ Rename Spec to AffineScheme #3345 #3425
- Remove two mentions of Arb_jll #3431
- Tweak epimorphism_from_free_group #3430
- CI: re-enable nightly #3435
- support gen(G::GAPGroup, 0) #3332
- Align all_*_groups methods some more #3433
- Add all_perfect_groups #3434
- Add all_primitive_groups and all_transitive_groups variants taking a single int or int range #3404
- fix a docstring #3436
- Fixes multivariate division #3396
- Docu invariants tori #3428
- Improve docstrings for is_conjugate/is_conjugate_with_data. #3384
- Fix ambient_module(M::SubquoModule) #3448
- Bugfix for printing of affine schemes #3437
- Bugfix for bugfix for printing of affine schemes #3445
- Update OSCAR banner #3410
- Docu invariants lin. red. groups (Lakshmi Ramesh and Wolfram Decker) #3443
- add od_from_atlas_group, od_from_p_subgroup, and helpers #3444
- Unexport normalise #3453
- support group properties for character tables #3449
- add docstrings for acting_group and action_function #3432 (exports are used in new groups code for the book)
- Adjust to renaming of rank(A::FinGenAbGroup) to torsion_free_rank(A::FinGenAbGroup) #3457
- Ensure fp_group(G) transfers group attributes #3464
- Added comment on convention #3467
- Export weierstrass_chart_on_minimal_model and patch transform_to_weierstrass #3458
- Fix a doc signature #3466
- Grading + caching for affine algebra of torus invariants #3469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using GAP ; using Oscar shows banner for OscarInterface package
5 participants