Grading + caching for affine algebra of torus invariants #3469
Conversation
| z.fundamental = torus_invariants_fast(weights(R), polynomial_ring(z)) | ||
| return z.fundamental | ||
| end | ||
| @attr function fundamental_invariants(z::TorGrpInvRing) |
There was a problem hiding this comment.
| @attr function fundamental_invariants(z::TorGrpInvRing) | |
| @attr SomeType function fundamental_invariants(z::TorGrpInvRing) |
Please add the return type here to make the attribute lookup type stable
There was a problem hiding this comment.
I don't know what type to use here other than Vector{MPolyRingElem} or Vector{MPolyDecRingElem} - which are not concrete types.
There was a problem hiding this comment.
Faced the same issue with the other file - InvariantTheory.jl
There was a problem hiding this comment.
That's true. In most other places, we would add the field type as a type parameter to the invariant ring, which would then allow something smarter here.
But I think this is out of scope for this PR.
@fingolfin can you keep this in mind for some future refactoring?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, I typed to slow. We can keep this here as is and I look into it in #3442.
There was a problem hiding this comment.
@lgoettgens sure, I actually had pointed out the same issue on a prior PR. We'll get there eventually ;-)
| @@ -399,10 +392,14 @@ julia> affine_algebra(RT) | |||
| (Quotient of multivariate polynomial ring by ideal (-t[1]*t[3] + t[2]^2), Hom: quotient of multivariate polynomial ring -> graded multivariate polynomial ring) | |||
| ``` | |||
| """ | |||
| function affine_algebra(R::TorGrpInvRing) | |||
| @attr function affine_algebra(R::TorGrpInvRing) | |||
There was a problem hiding this comment.
| @attr function affine_algebra(R::TorGrpInvRing) | |
| @attr SomeType function affine_algebra(R::TorGrpInvRing) |
Here as well
|
The doctest needs to be adjusted: The return type of |
* TorGrpInvRing to attributes, added test for affine_algebra for tori * graded affine algebra ring * fix to doctest (cherry picked from commit b6f11d0)
benlorenz
removed
the
backport 1.0.x
- Add QQBar docs to the manual #3423 - do not show the OscarInterface banner #3422 - fix bugs in all_OD_infos #3419 - Ep/ Rename Spec to AffineScheme #3345 #3425 - Remove two mentions of Arb_jll #3431 - Tweak epimorphism_from_free_group #3430 - CI: re-enable nightly #3435 - support gen(G::GAPGroup, 0) #3332 - Align all_*_groups methods some more #3433 - Add all_perfect_groups #3434 - Add all_primitive_groups and all_transitive_groups variants taking a single int or int range #3404 - fix a docstring #3436 - Fixes multivariate division #3396 - Docu invariants tori #3428 - Improve docstrings for is_conjugate/is_conjugate_with_data. #3384 - Fix ambient_module(M::SubquoModule) #3448 - Bugfix for printing of affine schemes #3437 - Bugfix for bugfix for printing of affine schemes #3445 - Update OSCAR banner #3410 - Docu invariants lin. red. groups (Lakshmi Ramesh and Wolfram Decker) #3443 - add od_from_atlas_group, od_from_p_subgroup, and helpers #3444 - Unexport normalise #3453 - support group properties for character tables #3449 - add docstrings for acting_group and action_function #3432 (exports are used in new groups code for the book) - Adjust to renaming of rank(A::FinGenAbGroup) to torsion_free_rank(A::FinGenAbGroup) #3457 - Ensure fp_group(G) transfers group attributes #3464 - Added comment on convention #3467 - Export weierstrass_chart_on_minimal_model and patch transform_to_weierstrass #3458 - Fix a doc signature #3466 - Grading + caching for affine algebra of torus invariants #3469
No description provided.