Introduce and use ScanSummary.EMPTY
#5937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 57.95% // Head: 57.95% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #5937 +/- ##
=========================================
Coverage 57.95% 57.95%
Complexity 2057 2057
=========================================
Files 322 322
Lines 18666 18666
Branches 3759 3759
=========================================
Hits 10817 10817
Misses 6802 6802
Partials 1047 1047
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fviernau
force-pushed
the
scan-summary-empty-copy
branch
3 times, most recently
from
ab423c4
to
17aae9d
Compare
sschuberth
requested changes
Oct 12, 2022
fviernau
force-pushed
the
scan-summary-empty-copy
branch
from
17aae9d
to
2994ec1
Compare
sschuberth
approved these changes
Oct 12, 2022
The constant can be used with the `copy` function to conveniently create an instance with only some values set. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Slightly simplify an upcoming change. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Improve readability of the caller code. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Use named arguments, inline a variable to end up with an expression function. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The test does cover the values used for these times. So, use `Instant.EPOCH` for making the value deterministic, for aligning with other "empty" default values. While at it also inline the variable to simplify an upcoming change. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Eliminate repeating default values by removing constructor calls in favor of using `ScanSummary.EMPTY.copy()`. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
scan-summary-empty-copy
branch
from
2994ec1
to
9b63690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates repetition of default values in scan summary constructions.
It prepares for further refactoring steps.
Part of #5681.