Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce and use ScanSummary.EMPTY #5937

Merged
merged 7 commits into from
Oct 12, 2022
Merged

Introduce and use ScanSummary.EMPTY #5937

merged 7 commits into from
Oct 12, 2022

Commits on Oct 12, 2022

  1. ScanSummary: Add a constant for an empty summary 

    The constant can be used with the `copy` function to conveniently
create an instance with only some values set.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
    @fviernau
    fviernau committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    0cef925 View commit details
    Browse the repository at this point in the history

  2. AbstractProvenanceBasedStorageFunTest: Inline a function 

    Slightly simplify an upcoming change.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
    @fviernau
    fviernau committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    8bcfa67 View commit details
    Browse the repository at this point in the history

  3. FossIdReporterTest: Change a parameter type from List to vararg 

    Improve readability of the caller code.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
    @fviernau
    fviernau committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    415544b View commit details
    Browse the repository at this point in the history

  4. FossIdReporterTest: Avoid turning a temporary map into a sorted map 

    Signed-off-by: Frank Viernau <frank_viernau@epam.com>
    @fviernau
    fviernau committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    beef2a5 View commit details
    Browse the repository at this point in the history

  5. FossIdReporterTest: Improve createScanResult() 

    Use named arguments, inline a variable to end up with an expression
function.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
    @fviernau
    fviernau committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    b76e577 View commit details
    Browse the repository at this point in the history

  6. ScannerIntegrationFunTest: Use Instant.EPOCH as start and end time 

    The test does cover the values used for these times. So, use
`Instant.EPOCH` for making the value deterministic, for aligning with
other "empty" default values. While at it also inline the variable to
simplify an upcoming change.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
    @fviernau
    fviernau committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    800483c View commit details
    Browse the repository at this point in the history

  7. Consistently use ScanSummary.EMPTY.copy() in test code 

    Eliminate repeating default values by removing constructor calls in
favor of using `ScanSummary.EMPTY.copy()`.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
    @fviernau
    fviernau committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    9b63690 View commit details
    Browse the repository at this point in the history