kind: Pin metallb to v0.14.8 #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cherry-pick release-1.0 |
There are some expectation at the dev-env interface at metallb that can change and break ovn-k CI, let's pin it so we can propertly consume those changes at a PR later on. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
tssurya
reviewed
Sep 11, 2024
| @@ -122,12 +122,13 @@ install_ingress() { | |||
|
|
|||
| METALLB_DIR="/tmp/metallb" | |||
| install_metallb() { | |||
| local metallb_version=v0.14.8 | |||
There was a problem hiding this comment.
hmm why not 0.14.18 the latest version?
any specific reason for choosing .8?
There was a problem hiding this comment.
The .8 tag corresponds to .18 release, don't know why though.
@tssurya -> https://github.com/metallb/metallb/releases/tag/v0.14.8
There was a problem hiding this comment.
The metallb mtaintainers has confirm me that the metallb release name is wrong, the proper version is the tag version, so we are all good.
tssurya
approved these changes
Sep 11, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
There are some expectation at the dev-env interface at metallb that can change and break ovn-k CI, let's pin it so we can propertly consume those changes at a PR later on.
Special notes for reviewers
This need to be cherry-pick to proper branches:
Does this PR introduce a user-facing change?
NONE