Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint/no-fallthrough #597

Closed
Tracked by #479
DonIsaac opened this issue Jul 24, 2023 · 1 comment · Fixed by #3673
Closed
Tracked by #479

feat(linter): eslint/no-fallthrough #597

DonIsaac opened this issue Jul 24, 2023 · 1 comment · Fixed by #3673
Labels
A-linter Area - Linter E-Help Wanted Experience level - For the experienced collaborators

Comments

@DonIsaac
Copy link
Collaborator

DonIsaac commented Jul 24, 2023 •
edited
Loading

Implement ESLint's no-fallthrough rule.

Start by running

just new-rule no-fallthrough
@DonIsaac DonIsaac mentioned this issue Jul 24, 2023
Open
@DonIsaac DonIsaac changed the title no-fallthrough feat(linter): eslint/no-fallthrough Jul 24, 2023
@DonIsaac DonIsaac added good first issue Experience Level - Good for newcomers A-linter Area - Linter labels Jul 24, 2023
@suica suica mentioned this issue Jul 26, 2023
Merged
3 tasks
@suica
Copy link
Contributor

suica commented Jul 26, 2023

This rule requires code reachability test as a prerequisite. So I will temporarily stop working on implementing it...

@DonIsaac DonIsaac added E-Help Wanted Experience level - For the experienced collaborators and removed good first issue Experience Level - Good for newcomers labels Jul 26, 2023
@suica suica mentioned this issue Jul 28, 2023
Closed
5 tasks
@rzvxa rzvxa mentioned this issue Jun 14, 2024
Merged
Boshen pushed a commit that referenced this issue Jun 17, 2024
@rzvxa
feat(linter): add no-fallthrough. (#3673)
080ecbd 
[no-fallthrough](https://eslint.org/docs/latest/rules/no-fallthrough)

[oxlint-ecosystem-ci](https://github.com/rzvxa/oxlint-ecosystem-ci/actions/runs/9546510803)

related to #633 and closes #597
also related to #3662
@rzvxa rzvxa closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linter Area - Linter E-Help Wanted Experience level - For the experienced collaborators
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(linter): add no-fallthrough. oxc-project/oxc
3 participants
@rzvxa @suica @DonIsaac