refactor(ast): make AstBuilder Copy
#3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
github-actions
bot
added
A-ast
CodSpeed Performance ReportMerging #3602 will not alter performanceComparing Summary
|
Merge activity
|
`AstBuilder` only contains a shared ref `&Allocator`. So make it `Copy` and pass around `AstBuilder<'a>` instead of `&AstBuilder<'a>` - 1 less level of indirection. Hopefully this will have little effect on benchmarks as all `AstBuilder`'s methods are marked `#[inline]`, but this change will minimize impact if compiler decides not to inline for some reason.
Boshen
force-pushed
the
06-10-refactor_ast_make_astbuilder_copy_
branch
from
5aab518
to
08f1010
Compare
Boshen
pushed a commit
that referenced
this pull request
Jun 10, 2024
This was referenced Jun 12, 2024
Closed
Merged
Boshen
added a commit
that referenced
this pull request
Jun 12, 2024
## [0.14.0] - 2024-06-12 ### Breaking * fix(codegen)!: remove the unecessary 4th argument from `Codegen::new` (#3640) * feat(ast)!: make `Trivias` clonable by adding `Arc` (#3638) ### Features - f6d9ca6 linter: Add `eslint/sort-imports` rule (#3568) (Wang Wenzhe) - 129f91e span: Port over more methods from TextRange (#3592) (Don Isaac) ### Bug Fixes - f8f6d33 ast: Correct `visited_node` attr for strict mode of arrow fns (#3635) (overlookmotel) - e6ad3fb diagnostics: Do not print ansi color codes in non-TTYs (#3624) (Boshen) - d65202d span: Correct doc comments (#3608) (overlookmotel) - 35e267b transformer: Arrow function transform use UIDs for `_this` vars (#3634) (overlookmotel) - 39bdebc transformer: Arrow func transform maintain scope ID (#3633) (overlookmotel) - 5cb7e6a transformer: Arrow func transform use correct spans (#3630) (overlookmotel) - 0c4ccb4 transformer: Arrow function transform alter `</this>` (#3627) (overlookmotel) - 8d237c4 transformer: JSX source calculate correct column when Unicode chars (#3615) (overlookmotel) - 9e8f4d6 transformer: Do not add `__source` for generated nodes (#3614) (overlookmotel) - 0fb4c35 transformer: Use UID for JSX source filename var (#3612) (overlookmotel) ### Performance - 3a59294 transformer: React display name transform reduce Atom allocations (#3616) (overlookmotel) - f4c1389 transformer: Create `Vec` with capacity (#3613) (overlookmotel) ### Refactor - 0f92521 ast: Replace recursion with loop (#3626) (overlookmotel) - 08f1010 ast: Make `AstBuilder` `Copy` (#3602) (overlookmotel) - 84304b4 linter: Add a `ctx.module_record()` method (#3637) (Boshen) - f98f777 linter: Add rule fixer (#3589) (Don Isaac) - e90e6a2 minifier: Make `Prepass` `Copy` (#3603) (overlookmotel) - 7d61832 semantic: Pass `Rc` by value (#3586) (overlookmotel) - 89bcbd5 transformer: Move `BoundIdentifier` into helpers (#3610) (overlookmotel) - 5793ff1 transformer: Replace `&’a Trivias` with `Rc<Trivias>` (#3580) (Dunqing) - 509871f transformer: Comment for unimplemented `spec` option in arrow fns transform (#3618) (overlookmotel) - 4b2e3a7 transformer: Fix indentation (#3617) (overlookmotel) - 3467e3d transformer: Remove outdated comment (#3606) (overlookmotel) - a799225 transformer: Flatten file structure for React transform (#3604) (overlookmotel) - 70f31a8 transformer: Reduce branching in JSX transform (#3596) (overlookmotel) - 3ae567d transformer: Remove dead code (#3588) (overlookmotel) - 60cbdec traverse: `generate_uid_in_root_scope` method (#3611) (overlookmotel) Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AstBuilderonly contains a shared ref&Allocator. So make itCopyand pass aroundAstBuilder<'a>instead of&AstBuilder<'a>- 1 less level of indirection.Hopefully this will have little effect on benchmarks as all
AstBuilder's methods are marked#[inline], but this change will minimize impact if compiler decides not to inline for some reason.