Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ast): make AstBuilder Copy #3602

Merged
merged 1 commit into from
Jun 10, 2024
Merged

refactor(ast): make AstBuilder Copy #3602

merged 1 commit into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. refactor(ast): make AstBuilder Copy (#3602) 

    `AstBuilder` only contains a shared ref `&Allocator`. So make it `Copy` and pass around `AstBuilder<'a>` instead of `&AstBuilder<'a>` - 1 less level of indirection.

Hopefully this will have little effect on benchmarks as all `AstBuilder`'s methods are marked `#[inline]`, but this change will minimize impact if compiler decides not to inline for some reason.
    @overlookmotel
    overlookmotel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    08f1010 View commit details
    Browse the repository at this point in the history