refactor(semantic): should not add symbols of ClassExpression and FunctionExpression to the scope

[Dunqing]

TypeScript Behavior

1. Create a symbol for the id of ClassExpression and FunctionExpression but doesn't add to the scope
   ClassExpression: https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/binder.ts#L3598-L3605
   FunctionExpression: https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/binder.ts#L3714-L3726

2. Different resolve logic is implemented specifically for these ASTs.
   ClassExpression: https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/utilities.ts#L11310-L11316
   FunctionExpression: https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/utilities.ts#L11375-L11378

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Dunqing]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(semantic): add some scopes to align TypeScript's container #3969
• refactor(semantic): add strict mode in scope flags for class definitions #4156
• refactor(semantic): should not add symbols of ClassExpression and FunctionExpression to the scope #4141 👈
• feat(semantic): align class scope with typescript #4195 : 1 other dependent PR (#4225 )
• refactor(semantic): set current_scope_id to scope_id in enter_scope #4193
• refactor(semantic): correct scope in CatchClause #4192
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4141 will degrade performances by 3.12%

_{Comparing 07-10-refactor_semantic_should_not_add_symbols_of_classexpression_and_functionexpression_to_the_scope (520d1f1) with 07-11-feat_semantic_align_class_scope_with_typescript (2634b62)}

Summary

❌ 1 regressions
✅ 30 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	07-11-feat_semantic_align_class_scope_with_typescript	07-10-refactor_semantic_should_not_add_symbols_of_classexpression_and_functionexpression_to_the_scope	Change
❌	semantic[pdf.mjs]	32 ms	33 ms	-3.12%