Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use scope way #4225

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 12, 2024

No description provided.

Copy link

graphite-app bot commented Jul 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Jul 12, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Jul 12, 2024

CodSpeed Performance Report

Merging #4225 will degrade performances by 62.72%

Comparing 07-12-refactor_use_scope_way (52172cf) with main (92ee774)

Summary

❌ 4 regressions
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 07-12-refactor_use_scope_way Change
minifier[antd.js] 350.7 ms 940.7 ms -62.72%
minifier[typescript.js] 648.8 ms 739.6 ms -12.29%
semantic[antd.js] 196.9 ms 406.6 ms -51.57%
transformer[antd.js] 320 ms 530.3 ms -39.66%

@Boshen Boshen deleted the 07-12-refactor_use_scope_way branch September 11, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant