Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ast): align ts ast scope with typescript #4253

Merged
merged 1 commit into from
Jul 17, 2024
Merged

feat(ast): align ts ast scope with typescript #4253

merged 1 commit into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. feat(ast): align ts ast scope with typescript (#4253) 

    close: #3969
close: #2023

We need to add scope according to [this](https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/binder.ts#L3883-L3962). There are still some ASTs that need to be added to the scope.

---

Context from @Boshen:

Before this whole journey of fixing symbols and scopes I asked @Dunqing to debug through binder.ts via a debugger to fully understand how it does resolution.

We then agreed to align the implementation so that when a problem occurs, we can debug through both implementations and find where our problem is.

tsc doesn't have a specification, so we need to align with the reference implementation instead.
    @Dunqing
    Dunqing committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    af4dc01 View commit details
    Browse the repository at this point in the history