feat(ast): align ts ast scope with typescript #4253

Dunqing · 2024-07-14T15:28:57Z

close: #3969
close: #2023

We need to add scope according to this. There are still some ASTs that need to be added to the scope.

Context from @Boshen:

Before this whole journey of fixing symbols and scopes I asked @Dunqing to debug through binder.ts via a debugger to fully understand how it does resolution.

We then agreed to align the implementation so that when a problem occurs, we can debug through both implementations and find where our problem is.

tsc doesn't have a specification, so we need to align with the reference implementation instead.

graphite-app · 2024-07-14T15:29:02Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Dunqing · 2024-07-14T15:29:10Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

codspeed-hq · 2024-07-14T15:34:10Z

CodSpeed Performance Report

Merging #4253 will not alter performance

_{Comparing 07-14-feat_ast_align_ts_ast_scope_with_typescript (af4dc01) with main (1f8968a)}

Summary

✅ 32 untouched benchmarks

tasks/coverage/parser_typescript.snap

graphite-app · 2024-07-17T02:49:56Z

Merge activity

Jul 16, 10:49 PM EDT: Boshen added this pull request to the Graphite merge queue.
Jul 16, 10:54 PM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen

close: #3969 close: #2023 We need to add scope according to [this](https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/binder.ts#L3883-L3962). There are still some ASTs that need to be added to the scope. --- Context from @Boshen: Before this whole journey of fixing symbols and scopes I asked @Dunqing to debug through binder.ts via a debugger to fully understand how it does resolution. We then agreed to align the implementation so that when a problem occurs, we can debug through both implementations and find where our problem is. tsc doesn't have a specification, so we need to align with the reference implementation instead.

## [0.21.0] - 2024-07-18 - d7ab0b8 semantic: [**BREAKING**] Simplify node creation (#4226) (lucab) ### Features - af4dc01 ast: Align ts ast scope with typescript (#4253) (Dunqing) - 83c2c62 codegen: Add option for choosing quotes; remove slow `choose_quot` method (#4219) (Boshen) - 5d17675 mangler: Add debug mode (#4314) (Boshen) - e3e663b mangler: Initialize crate and integrate into minifier (#4197) (Boshen) - c818472 minifier: Dce conditional expression `&&` or `||` (#4190) (Boshen) - 8a190eb oxc: Export `oxc_mangler` (Boshen) - 20cdb1f semantic: Align class scope with typescript (#4195) (Dunqing) - 92ee774 semantic: Add `ScopeFlags::CatchClause` for use in CatchClause (#4205) (Dunqing) - 205c259 sourcemap: Support SourceMapBuilder#token_chunks (#4220) (underfin) - 7eb960d transformer: Decode xml character entity `&#xhhhh` and `&#nnnn;` (#4235) (Boshen) ### Bug Fixes - bf3d8d3 codegen: Print annotation comment inside parens for new and call expressions (#4290) (Boshen) - 084ab76 codegen: Use `ryu-js` for f64 to string (Boshen) - e167ef7 codegen: Print parenthesis properly (#4245) (Boshen) - c65198f codegen: Choose the right quote for jsx attribute string (#4236) (Boshen) - be82c28 codegen: Print `JSXAttributeValue::StringLiteral` directly (#4231) (Boshen) - 3df9e69 mangler: No shorthand `BindingProperty`; handle var hoisting and export variables (#4319) (Boshen) - f144082 minifier: RemoveDeadCode should visit nested expression (#4268) (underfin) - 66b455a oxc_codegen: Avoid print same pure comments multiple time (#4230) (IWANABETHATGUY) - 9a87e41 parser: Avoid crashing on invalid const modifier (#4267) (lucab) - 641a78b parser: Fix tests for number parsing (#4254) (overlookmotel) - 9badac0 semantic: Avoid var hosting insert the var variable to the `CatchClause` scope (#4337) (Dunqing) - 95e15b6 semantic: Incorrect resolve references for `ExportSpecifier` (#4320) (Dunqing) - c362bf7 semantic: Incorrect resolve references for `TSInterfaceHeritage` (#4311) (Dunqing) - 351ecf2 semantic: Incorrect resolve references for `TSTypeQuery` (#4310) (Dunqing) - 1108f2a semantic: Resolve references to the incorrect symbol (#4280) (Dunqing) - 22d56bd semantic: Do not resolve references after `FormalParameters` in TS type (#4241) (overlookmotel)- 1c117eb Avoid print extra semicolon after accessor property (#4199) (IWANABETHATGUY) ### Performance - a8dc4f3 parser: Speed up parsing numbers with `_` separators (#4259) (overlookmotel) - b94540d parser: Speed up parsing octal literals (#4258) (overlookmotel) - a7b328c parser: Faster parsing decimal numbers (#4257) (overlookmotel) - f9d3f2e semantic: Inline ast record functions (#4272) (overlookmotel) - 8fad7db semantic: Reduce `AstNodeId` to `u32` (#4264) (overlookmotel) - 23743db semantic: Do not record ast nodes for cfg if cfg disabled (#4263) (overlookmotel) - da69076 semantic: Reduce overhead of cfg recording ast nodes (#4262) (overlookmotel) - cb15303 semantic: Reduce memory copies (#4216) (overlookmotel) - ef4c1f4 semantic: Reduce lookups (#4214) (overlookmotel) - f23e54f semantic: Recycle unresolved references hash maps (#4213) (overlookmotel) - 2602ce2 semantic: Reuse existing map of unresolved refs (#4206) (lucab) ### Refactor - 2c7bb9f ast: Pass final `ScopeFlags` into `visit_function` (#4283) (overlookmotel) - 3e099fe ast: Move `enter_scope` after `visit_binding_identifier` (#4246) (Dunqing) - aab7aaa ast/visit: Fire node events as the outermost one. (#4203) (rzvxa) - d1c4be0 codegen: Clean up annotation_comment (Boshen) - 06197b8 codegen: Separate tests (Boshen) - aa22073 codegen: Improve print API (#4196) (Boshen) - c5731a5 semantic: Remove defunct code setting ScopeFlags twice (#4286) (overlookmotel) - 16698bc semantic: Move function/class-specific code into specific visitors (#4278) (overlookmotel) - ee16668 semantic: Rename function param (#4277) (overlookmotel) - 25f0771 semantic: Alter syntax of `control_flow!` macro (#4275) (overlookmotel) - 639fd48 semantic: Comment why extra CFG enabled check (#4274) (overlookmotel) - c418bf5 semantic: Directly record `current_node_id` when adding a scope (#4265) (Dunqing) - ace4f1f semantic: Update the order of `visit_function` and `Visit` fields in the builder to be consistent (#4248) (Dunqing) - 8bfeabf semantic: Simplify adding `SymbolFlags::Export` (#4249) (Dunqing) - dc2b3c4 semantic: Add strict mode in scope flags for class definitions (#4156) (Dunqing) - 81ed588 semantic: Convert scope fields to IndexVecs (#4208) (lucab) - bbe5ded semantic: Set `current_scope_id` to `scope_id` in `enter_scope` (#4193) (Dunqing) - 7f1addd semantic: Correct scope in CatchClause (#4192) (Dunqing) - fc0b17d syntax: Turn the `AstNodeId::dummy` into a constant field. (#4308) (rzvxa) - a197e01 transformer/typescript: Remove unnecessary code (#4321) (Dunqing) - 1458d81 visit: Add `#[inline]` to empty functions (#4330) (overlookmotel) Co-authored-by: Boshen <Boshen@users.noreply.github.com>

github-actions bot added A-semantic Area - Semantic A-ast Area - AST labels Jul 14, 2024

Dunqing force-pushed the 07-14-feat_ast_align_ts_ast_scope_with_typescript branch from cf11d22 to d1a2a11 Compare July 14, 2024 15:34

Boshen self-requested a review July 14, 2024 16:02

Boshen reviewed Jul 14, 2024

View reviewed changes

tasks/coverage/parser_typescript.snap Show resolved Hide resolved

Dunqing force-pushed the 07-14-feat_ast_align_ts_ast_scope_with_typescript branch from d1a2a11 to e60f0ba Compare July 15, 2024 15:30

Dunqing mentioned this pull request Jul 15, 2024

fix(semantic): resolve references to the incorrect symbol #4280

Merged

Boshen requested review from overlookmotel and rzvxa July 15, 2024 15:36

Dunqing force-pushed the 07-14-feat_ast_align_ts_ast_scope_with_typescript branch from e60f0ba to 7c33978 Compare July 16, 2024 07:44

Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 17, 2024 — with Graphite App

Boshen force-pushed the 07-14-feat_ast_align_ts_ast_scope_with_typescript branch from 7c33978 to af4dc01 Compare July 17, 2024 02:51

graphite-app bot merged commit af4dc01 into main Jul 17, 2024
25 checks passed

graphite-app bot deleted the 07-14-feat_ast_align_ts_ast_scope_with_typescript branch July 17, 2024 02:54

This was referenced Jul 17, 2024

Release crates v0.21.0 #4325

Closed

Release crates v0.21.0 #4338

Merged

github-actions bot mentioned this pull request Jul 18, 2024

Release crates v0.21.0 #4344

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ast): align ts ast scope with typescript #4253

feat(ast): align ts ast scope with typescript #4253

Dunqing commented Jul 14, 2024 •

edited by Boshen

Loading

graphite-app bot commented Jul 14, 2024

Dunqing commented Jul 14, 2024 •

edited

Loading

codspeed-hq bot commented Jul 14, 2024 •

edited

Loading

graphite-app bot commented Jul 17, 2024 •

edited

Loading

feat(ast): align ts ast scope with typescript #4253

feat(ast): align ts ast scope with typescript #4253

Conversation

Dunqing commented Jul 14, 2024 • edited by Boshen Loading

graphite-app bot commented Jul 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Dunqing commented Jul 14, 2024 • edited Loading

codspeed-hq bot commented Jul 14, 2024 • edited Loading

CodSpeed Performance Report

Merging #4253 will not alter performance

Summary

graphite-app bot commented Jul 17, 2024 • edited Loading

Merge activity

Dunqing commented Jul 14, 2024 •

edited by Boshen

Loading

Dunqing commented Jul 14, 2024 •

edited

Loading

codspeed-hq bot commented Jul 14, 2024 •

edited

Loading

graphite-app bot commented Jul 17, 2024 •

edited

Loading