Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(linter-macros): only iterate over all rules once #4672

Merged

Conversation

DonIsaac
Copy link
Collaborator

@DonIsaac DonIsaac commented Aug 5, 2024

No description provided.

Compile insta and its diffing library in release mode. After the initial build, I'm seeing ~1s shaved off `cargo test` locally.
@DonIsaac DonIsaac marked this pull request as ready for review August 5, 2024 21:10
Copy link
Collaborator Author

DonIsaac commented Aug 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Aug 5, 2024

CodSpeed Performance Report

Merging #4672 will not alter performance

Comparing don/08-05-perf_linter-macros_only_iterate_over_all_rules_once (1ccd598) with main (e8b662a)

Summary

✅ 32 untouched benchmarks

Copy link

graphite-app bot commented Aug 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac requested a review from Dunqing August 5, 2024 23:00
Base automatically changed from don/build/insta-dev-release to main August 6, 2024 00:51
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Dunqing Dunqing merged commit 69c6b65 into main Aug 6, 2024
28 checks passed
@Dunqing Dunqing deleted the don/08-05-perf_linter-macros_only_iterate_over_all_rules_once branch August 6, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants