perf(linter-macros): only iterate over all rules once

Cargo.toml

@@ -198,6 +198,10 @@ debug = false
 # Compile macros with some optimizations to make consuming crates build faster
 oxc_macros.opt-level     = 1
 oxc_ast_macros.opt-level = 1
+# Compile insta and its dependencies in release mode for faster snapshot tests
+# See: https://insta.rs/docs/quickstart/#optional-faster-runs
+insta.opt-level          = 3
+similar.opt-level        = 3
 
 [profile.release.package.oxc_wasm]
 opt-level = 'z'

crates/oxc_macros/src/declare_all_lint_rules.rs

@@ -1,4 +1,5 @@
 use convert_case::{Case, Casing};
+use itertools::Itertools as _;
 use proc_macro::TokenStream;
 use quote::quote;
 use syn::{
@@ -37,18 +38,25 @@ impl Parse for AllLintRulesMeta {
 #[allow(clippy::cognitive_complexity, clippy::too_many_lines)]
 pub fn declare_all_lint_rules(metadata: AllLintRulesMeta) -> TokenStream {
     let AllLintRulesMeta { rules } = metadata;
-    let use_stmts = rules.iter().map(|rule| &rule.path).collect::<Vec<_>>();
-    let struct_names = rules.iter().map(|rule| &rule.name).collect::<Vec<_>>();
-    let plugin_names = rules.iter().map(|node| {
-        node.path
-            .segments
-            .iter()
-            .take(node.path.segments.len() - 1)
-            .map(|s| format!("{}", s.ident))
-            .collect::<Vec<_>>()
-            .join("/")
-    });
-    let ids = rules.iter().enumerate().map(|(i, _)| i).collect::<Vec<_>>();
+
+    let mut use_stmts = Vec::with_capacity(rules.len());
+    let mut struct_names = Vec::with_capacity(rules.len());
+    let mut plugin_names = Vec::with_capacity(rules.len());
+    let mut ids = Vec::with_capacity(rules.len());
+
+    for (i, rule) in rules.iter().enumerate() {
+        use_stmts.push(&rule.path);
+        struct_names.push(&rule.name);
+        plugin_names.push(
+            rule.path
+                .segments
+                .iter()
+                .take(rule.path.segments.len() - 1)
+                .map(|s| format!("{}", s.ident))
+                .join("/"),
+        );
+        ids.push(i);
+    }
 
     let expanded = quote! {
         #(pub use self::#use_stmts::#struct_names;)*